Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dmg maker (Intel): Cannot find module '../build/Release/volume.node' #3845

Closed
3 tasks done
WyattBlue opened this issue Feb 9, 2025 · 6 comments
Closed
3 tasks done

Comments

@WyattBlue
Copy link

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Forge version

7.6.1

Electron version

v33.4.0

Operating system

macOS 14.7.3 (Intel)

Last known working Forge version

7.5.0

Expected behavior

npm run make

Makes the app and dmg without errors

Actual behavior

The .app is made but the dmg maker fails.

❯ Making distributables
  ✖ Making a dmg distributable for darwin/x64
    › Cannot find module '../build/Release/volume.node'
      Require stack:
      - /Users/wyattblue/projects/app/node_modules/macos-alias/lib/create.js
      - /Users/wyattblue/projects/app/node_modules/macos-alias/index.js
      - /Users/wyattblue/projects/app/node_modules/ds-store/index.js
      - /Users/wyattblue/projects/app/node_modules/appdmg/lib/appdmg.js
      - /Users/wyattblue/projects/app/node_modules/appdmg/index.js
      - /Users/wyattblue/projects/app/node_modules/electron-installer-dmg/dist/i
      ndex.js
      - /Users/wyattblue/projects/app/node_modules/@electron-forge/maker-dmg/dis
      t/MakerDMG.js
      - /Users/wyattblue/projects/app/node_modules/@electron-forge/core/helper/d
      ynamic-import.js
      - /Users/wyattblue/projects/app/node_modules/@electron-forge/core/dist/uti
      l/forge-config.js
      - /Users/wyattblue/projects/app/node_modules/@electron-forge/core/dist/uti
      l/index.js
      - /Users/wyattblue/projects/app/node_modules/@electron-forge/core/dist/api
      /index.js
      - /Users/wyattblue/projects/app/node_modules/@electron-forge/cli/dist/elec
      tron-forge-make.js
◼ Running postMake hook

An unhandled rejection has occurred inside Forge:
Error: Cannot find module '../build/Release/volume.node'
Require stack:
- /Users/wyattblue/projects/app/node_modules/macos-alias/lib/create.js
- /Users/wyattblue/projects/app/node_modules/macos-alias/index.js
- /Users/wyattblue/projects/app/node_modules/ds-store/index.js
- /Users/wyattblue/projects/app/node_modules/appdmg/lib/appdmg.js
- /Users/wyattblue/projects/app/node_modules/appdmg/index.js
- /Users/wyattblue/projects/app/node_modules/electron-installer-dmg/dist/index.js
- /Users/wyattblue/projects/app/node_modules/@electron-forge/maker-dmg/dist/MakerDMG.js
- /Users/wyattblue/projects/app/node_modules/@electron-forge/core/helper/dynamic-import.js
- /Users/wyattblue/projects/app/node_modules/@electron-forge/core/dist/util/forge-config.js
- /Users/wyattblue/projects/app/node_modules/@electron-forge/core/dist/util/index.js
- /Users/wyattblue/projects/app/node_modules/@electron-forge/core/dist/api/index.js
- /Users/wyattblue/projects/app/node_modules/@electron-forge/cli/dist/electron-forge-make.js
at Module._resolveFilename (node:internal/modules/cjs/loader:1225:15)
    at Module._load (node:internal/modules/cjs/loader:1051:27)
    at Module.require (node:internal/modules/cjs/loader:1311:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/Users/wyattblue/projects/app/node_modules/macos-alias/lib/create.js:7:13)
    at Module._compile (node:internal/modules/cjs/loader:1469:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
    at Module.load (node:internal/modules/cjs/loader:1288:32)
    at Module._load (node:internal/modules/cjs/loader:1104:12)
    at Module.require (node:internal/modules/cjs/loader:1311:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/Users/wyattblue/projects/app/node_modules/macos-alias/index.js:1:18)
    at Module._compile (node:internal/modules/cjs/loader:1469:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
    at Module.load (node:internal/modules/cjs/loader:1288:32)
    at Module._load (node:internal/modules/cjs/loader:1104:12)

Steps to reproduce

npx create-electron-app my-new-app
cd my-new-app
vim forge.config.js  # replace Darwin zip target with maker-dmg
npm run make

I'm using this maker

    {
      name: "@electron-forge/maker-dmg",
      platforms: ["darwin"],
      config: {
        format: "ULFO",
        iconSize: 150,
        overwrite: true,
      }
    },

The error only happens on Intel. on Apple Silicon (same OS version) the error doesn't happen.

Additional information

I tried downgrading from 7.6.1 to 7.5.0 but I still get the same problem. I don't think the actual problem is in forge itself, but with a transitive dependency, which I think is appdmg.

appdmg is nice, but it hasn't had any updates in 2 years. I would like for that dependency to be replaced.

@erickzhao erickzhao added the bug label Feb 11, 2025
@dongnaebi
Copy link

Any workaround?

@erickzhao
Copy link
Member

Potentially related based on the stack trace:

Could you try downgrading to v7.6.0 (or add a resolution for [email protected]) to confirm?

@WyattBlue
Copy link
Author

Downgrading electron-forge to 7.6.0 has the exact same error message as before.

Running

npm install [email protected] --save-exact

has this error (truncated):

...
43 error gyp verb architecture x64
43 error gyp verb node dev dir /Users/wyattblue/Library/Caches/node-gyp/20.18.3
43 error gyp verb python /Library/Frameworks/Python.framework/Versions/3.13/bin/python3
43 error gyp verb `which` succeeded for `make` /usr/bin/make
43 error gyp verb bin symlinks created symlink to "/Library/Frameworks/Python.framework/Versions/3.13/bin/python3" in "/Users/wyattblue/projects/app/node_modules/macos-alias/build/node_gyp_bins" and added to PATH
43 error gyp info spawn make
43 error gyp info spawn args [ 'V=1', 'BUILDTYPE=Release', '-C', 'build' ]
43 error In file included from ../src/volume.cc:2:
43 error In file included from ../../nan/nan.h:62:
43 error In file included from /Users/wyattblue/Library/Caches/node-gyp/20.18.3/include/node/node.h:73:
43 error /Users/wyattblue/Library/Caches/node-gyp/20.18.3/include/node/v8.h:21:10: fatal error: 'memory' file not found
43 error    21 | #include <memory>
43 error       |          ^~~~~~~~
43 error 1 error generated.
43 error make: *** [Release/obj.target/volume/src/volume.o] Error 1
43 error gyp ERR! build error 
43 error gyp ERR! stack Error: `make` failed with exit code: 2
43 error gyp ERR! stack at ChildProcess.<anonymous> (/Users/wyattblue/projects/app/node_modules/@electron/node-gyp/lib/build.js:215:23)
43 error gyp ERR! System Darwin 23.6.0
43 error gyp ERR! command "/usr/local/Cellar/node@20/20.18.3/bin/node" "/Users/wyattblue/projects/app/node_modules/.bin/node-gyp" "rebuild"
43 error gyp ERR! cwd /Users/wyattblue/projects/app/node_modules/macos-alias
43 error gyp ERR! node -v v20.18.3
43 error gyp ERR! node-gyp -v v10.2.0-electron.1
43 error gyp ERR! not ok
44 silly unfinished npm timer reify 1739996072435
45 silly unfinished npm timer reify:build 1739996076373
46 silly unfinished npm timer build 1739996076373
47 silly unfinished npm timer build:deps 1739996076373
48 silly unfinished npm timer build:run:install 1739996076377
49 silly unfinished npm timer build:run:install:node_modules/macos-alias 1739996076377
50 verbose cwd /Users/wyattblue/projects/app
51 verbose os Darwin 23.6.0
52 verbose node v20.18.3
53 verbose npm  v11.1.0
54 verbose exit 1
55 verbose code 1
56 error A complete log of this run can be found in: /Users/wyattblue/.npm/_logs/2025-02-19T20_14_32_028Z-debug-0.log

@WyattBlue
Copy link
Author

Upgrading to electron-forge 7.7.0, I get the <memory> error immediately, so it seems like that release is a step in the right direction.

@erickzhao
Copy link
Member

Found my way to:

Looks like reinstalling XCode Command Line Tools fixed the issue for some people?

@WyattBlue
Copy link
Author

Clean install xcode cl tools worked for me.

sudo rm -rf /Library/Developer/CommandLineTools
xcode-select --install

@erickzhao erickzhao removed their assignment Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants