From 42630d5948f7ba19b6072136fec84aa5033facaa Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Fri, 12 Jan 2024 19:48:32 +0100 Subject: [PATCH] fix: item label and icon for missing local --- src/renderer/components/version-select.tsx | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/renderer/components/version-select.tsx b/src/renderer/components/version-select.tsx index dc16751add..00f006ace7 100644 --- a/src/renderer/components/version-select.tsx +++ b/src/renderer/components/version-select.tsx @@ -66,8 +66,9 @@ const itemListRenderer: ItemListRenderer = ({ * @returns {string} */ export function getItemLabel({ source, state, name }: RunnableVersion): string { + // If a version is local, either it's there or it's not. if (source === VersionSource.local) { - return name || 'Local'; + return state === 'missing' ? 'Unavailable' : name || 'Local'; } const installStateLabels: Record = { @@ -87,7 +88,12 @@ export function getItemLabel({ source, state, name }: RunnableVersion): string { * @param {RunnableVersion} { state } * @returns {IconName} */ -export function getItemIcon({ state }: RunnableVersion): IconName { +export function getItemIcon({ source, state }: RunnableVersion): IconName { + // If a version is local, either it's there or it's not. + if (source === VersionSource.local) { + return state === InstallState.missing ? 'disable' : 'saved'; + } + const installStateIcons: Record = { missing: 'cloud', downloading: 'cloud-download',