Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] JSON diff view PoC (react-diff-viewer-continued) #172122

Conversation

banderror
Copy link
Contributor

Summary

Based on #172118

Contains a POC of rule JSON diff component based on the react-diff-viewer-continued library.

@banderror banderror force-pushed the rule-json-diff-poc-react-diff-viewer-continued branch 3 times, most recently from a8d1534 to 474b890 Compare November 29, 2023 03:05
@banderror banderror force-pushed the rule-json-diff-poc-react-diff-viewer-continued branch from 6f8f752 to 1190045 Compare November 29, 2023 04:22
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 4733 4747 +14

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.9MB 12.9MB +39.9KB

History

  • 💔 Build #179851 failed 6f8f752efb18cdd91f5b76be2be9c180ab3ab1d3
  • 💔 Build #179846 failed 474b890766978779c6c7ce094a2313451a496145
  • 💔 Build #179840 failed 46ad90cf8c7bd57e05b22a647cd9418ddd3891d1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@banderror banderror closed this Dec 28, 2023
@banderror banderror deleted the rule-json-diff-poc-react-diff-viewer-continued branch December 28, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants