Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EUI <> AnalystXP Priorities #182611

Open
10 of 20 tasks
timductive opened this issue May 3, 2024 · 12 comments
Open
10 of 20 tasks

EUI <> AnalystXP Priorities #182611

timductive opened this issue May 3, 2024 · 12 comments
Assignees
Labels
EUI impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Meta Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@timductive
Copy link
Member

timductive commented May 3, 2024

The following tasks are important to solve between EUI and Kibana.

Datagrid

  1. data grid feature request
  2. bug data grid ⚠️ needs validation
    tkajtoch
  3. data grid stale-issue stale-issue-closed
  4. data grid feature request
  5. data grid feature request
  6. data grid feature request help wanted stale-issue stale-issue-closed
  7. bug data grid
  8. data grid feature request help wanted
  9. data grid feature request
  10. data grid feature request
    cee-chen
  11. bug data grid
    cee-chen
  12. EUI Team:DataDiscovery blocked bug impact:low upstream
  13. data grid
    mgadewoll
  14. data grid feature request
    mgadewoll

UX Improvements

  1. feature request
  2. design decision feature request icons
    MichaelMarcialis
  3. feature request
    tkajtoch
  4. bug feature request
  5. accessibility - keyboard bug
    cee-chen
  6. EUI Team:Platform-Design bug
@timductive timductive added Meta impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. EUI Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels May 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@timductive timductive added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label May 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@yanwalton
Copy link

Hi @ninoslavmiskovic and @teresaalvarezsoler,

@timductive has put a list of issues together that he would like EUI to help with as part of our current prios for Discover and Dashboard. @JasonStoltz has assessed these from an EUI perspective with regards to effort / value, but it would be really helpful to combine that with your input with regard to how useful they are for your team's current and future efforts.

Would you be able to evaluate these issues and add a comment below with each issue listed with a Must have , Nice to have and Don't need... and simple explanation if needed.

We (Jason / EUI) will then take this input and work out which issues to focus on.

Thanks, and let me know if you have any questions.

@ninoslavmiskovic
Copy link
Contributor

From my perspective the data table /datagrid enhancement are important since we are making changes as part of the "One Discover" initiative and could be very handy to get fixed.

@JasonStoltz
Copy link
Member

JasonStoltz commented Jun 5, 2024

Hey team. I'm piecing together a recap here from various conversations I've had with folks. This is simply my current thinking, and nothing here is definite. I'm posting this in advance of when we meet next week to help organize ahead of time.

High priorities
[EuiCombobox] allow for multiline options of different height #7712
This seems like really bad UX and should be something we fix ASAP. We have this one queued up for 8.16.
[EuiComboBox] Broken keyboard interaction in x clear button #7289
We'd get this one for free if we do the above fix, so also queued up for 8.16.
[DataGrid] Enable Auto Fit behavior when Cell row height - Custom is selected #7835
[EuiDataGrid] Implement draggable columns with table headers #7136
This one both provides a much better user experience and is technically feasible. A large effort, but not huge. It seems like an easy win. Tim mentioned that this is higher priority than copy/paste improvements mentioned below.
[EuiDataGrid] Change header cell popover menu trigger element to be the verticalBoxes icon button #7660
This one would need to be done in order to do draggable column headers, and it should be relatively easy. We're planning to address this by 8.16 (or sooner) as well.
[EuiDataGrid] Issues with minimal height when browser zoom lower than 100% #6581
This is a bug and should be fixed.
[EuiDataGrid] Cell filtering UX unusable after scroll #7828
We should fix this bug

Medium / unclear priority
Remove new lines when copy/pasting in Discover #177952
We won't address this one directly. As an alternative, the Discover team will work on this functionality on their side instead
[EuiDataGrid] Add support for copying the focused cell's value with keyboard shortcut only #6561
Keyboard only usage is important to users, so this should be a priority. We're thinking about putting this on our Roadmap for next quarter (starting August 2024).

Low priority / won't fix
[EuiDataGrid] Provide an onFullScreenChange callback #7604
This appears to be tech debt, as there is already a work-around in place. However, Tim asked to put this at the top of our tech debt queue, which the EUI team will do.
[EuiDataGrid] bi-directional infinite scrolling #2981
I see the value here for sure, but it could also be a huge effort. We're not sure at this point if it's technically possible or not. IIRC this was attempted before for log streams and didn't end up in production because it was a massive amount of work.
Logs UI is interested in keeping this when they switch to data grid - they have it now so they don’t want to lose it.
Since it constitutes a significant amount of work, it would ideal to see some more user-based evidence for the need.
As it stands, none of our competitors actually have it either.
This is something the EUI team should consider spiking out in the next quarter.
Michael expressed a concern here about having a data grid embedded in the surrounding documents view, so it essentially creates a nested pagination experience, which is bad. Nino expressed an interest in re-thinking how we do surrounding documents, so this concern could potentially be alleviated by redesigning that.
For now, we're putting this in the low priority section until it's clear it needs to be a priority.

FWIW:

  • There is an escape hatch already for EuiDataGrid that let's them render the body any way they want
  • Instead of true infinite scrolling - could we add a "load more" row at the bottom of results to manually reload the results -- this is what Data Dog does

[EuiDataGrid] Allow sticky columns #2839
I see the value here for sure, but it could also be a huge effort. We're not sure at this point if it's technically possible or not.
Per Tim and Nino -- useful but hard to do, OK with marking as low and circling back to it later.
Question from Yan: Does the OP have additional context for "I got some feedback on a particularly wide usage of data grid where some people would like to lock some columns so that when they are forced to horizontally scroll" -- although as Nino mentioned, it is obvious that this could be a pain point if you have over a certain amount of columns. Increasing row heigh might actually fix this.
Sort fields panel position misaligned in full screen view #5894
Again, this seems like a relatively minor issue? And also large/tricky to fix. There could be a potential fix on the Discover side here by not using nested popovers. Also a long-standing issue.
Discussed with Tim and Nino - Michael M. to help redesign and it will go back to Tim's team to work
[EUI DataGrid] Pixel Column Widths Cause Scroll Bars #6683
This seems relatively minor? And being a large/tricky fix I'm not sure if we should make this a priority to address.
Nino and Tim to ask for a demo or more information about this to assess severity.
Some screenshots would help. When we played around with it in our live session it actually didn't seem to be too bad. The datagrid sizes neatly on initial render, and only appeared to be an issue after a user resizes the panel.
[EuiComboBox] Clearable functionality should work during text search/typing #5498
This seems very minor and @teresaalvarezsoler mentioned that she's not sure it's affecting dashboards/lens/discover UI. It's also been a known issue for over 3 years now.
[EuiComboBox] [EuiSelectable] allow for highlighting a custom fragment when using custom option matcher #7711
Large effort/low value -- per @teresaalvarezsoler "I think this is a nice-to-have, unless this is a super quick fix, we can cancel it."
[EuiDataGrid] Make column width editable / removable with keyboard #4019
This one seems like a nice-to-have. Would users actually use this? Have users asked for this? Also something we sized as a large effort.
[EuiDataGrid] Add column highlighting #7138
This seems like a nice visual, but in terms of priority relative to other work, seems like it would be low.

@timductive
Copy link
Member Author

One more bug-related issue to add to the discussion if we have time:
elastic/eui#7828

@JasonStoltz
Copy link
Member

@timductive I added #7828 to the high priority list. Thanks for adding that issue. I also updated my comment with all of the notes from our meeting if you'd like to review them.

@timductive
Copy link
Member Author

looks good, thanks @JasonStoltz

@kertal
Copy link
Member

kertal commented Jun 13, 2024

Adding a new one, which is important for our Contextual Logs Presentation : elastic/eui#7835, added it to the list

@ninoslavmiskovic
Copy link
Contributor

Adding a new one, which is important for our Contextual Logs Presentation : elastic/eui#7835, added it to the list

@JasonStoltz This is high priority also as part of One Discover initiative. Could you please take a look and estimate the effort. Thanks

@JasonStoltz
Copy link
Member

@ninoslavmiskovic I'll review this one with @kertal, I'm not sure I understand the ask.

@timductive timductive self-assigned this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EUI impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Meta Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

6 participants