From d079e9573d19e098e61effe619a93c50246f726a Mon Sep 17 00:00:00 2001 From: Cee Chen <549407+cee-chen@users.noreply.github.com> Date: Fri, 3 Nov 2023 10:19:31 -0700 Subject: [PATCH] Upgrade EUI to v90.0.0 (#170179) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `v89.1.0`⏩`v90.0.0` The majority of changes in this PR come from: - **EuiContextMenu** being converted to Emotion (https://github.com/elastic/eui/pull/7312). If your usage of `EuiContextMenu` was significantly affected, we recommend pulling down this PR and QAing it locally. - `defaultProps` being removed from some very widespread components, particularly **EuiButton**, in anticipation of React's upcoming deprecation. (https://github.com/elastic/eui/commit/b7dc9b4e896c552bec6c0c6b53103643ad9bbe6d) **NOTE**: This only affected Enzyme snapshots, and did not affect production behavior. [Commits](https://github.com/elastic/kibana/pull/170179/commits) have been broken up by component changes as well as types of changes. --- ## [`90.0.0`](https://github.com/elastic/eui/tree/v90.0.0) - Updated the `eventColor` prop on `EuiCommentEvent` to apply the color to the entire comment header. ([#7288](https://github.com/elastic/eui/pull/7288)) - Updated `EuiBasicTable` and `EuiInMemoryTable` to support a new controlled selection API: `selection.selected` ([#7321](https://github.com/elastic/eui/pull/7321)) **Bug fixes** - Fixed controlled `EuiFieldNumbers` not correctly updating native validity state ([#7291](https://github.com/elastic/eui/pull/7291)) - Fixed `EuiListGroupItem` to pass `style` props to the wrapping `
  • ` element alongside `className` and `css`. All other props will be passed to the underlying content. ([#7298](https://github.com/elastic/eui/pull/7298)) - Fixed `EuiListGroupItem`'s non-transitioned transform on hover/focus ([#7298](https://github.com/elastic/eui/pull/7298)) - Fixed `EuiDataGrid`s with `gridStyle.stripes` sometimes showing buggy row striping after being sorted ([#7301](https://github.com/elastic/eui/pull/7301)) - Fixed `EuiDataGrid`'s `gridStyle.rowClasses` API to not conflict with `gridStyle.stripes` if dynamically updated ([#7301](https://github.com/elastic/eui/pull/7301)) - Fixed `EuiDataGrid`'s `gridStyle.rowClasses` API to support multiple space-separated classes ([#7301](https://github.com/elastic/eui/pull/7301)) - Fixed `EuiInputPopover` not calling `onPanelResize` callback prop ([#7305](https://github.com/elastic/eui/pull/7305)) - Fixed `EuiDualRange` incorrectly positioning highlights when rendered with `showInput="inputWithPopover"` ([#7305](https://github.com/elastic/eui/pull/7305)) - Fixed `EuiTabs` incorrectly wrapping text when it should instead either scroll or truncate ([#7309](https://github.com/elastic/eui/pull/7309)) - `EuiContextMenu` now renders text colors correctly when used within an `EuiBottomBar` ([#7312](https://github.com/elastic/eui/pull/7312)) - Fixed the width of `EuiSuperDatePicker`'s Absolute date picker ([#7313](https://github.com/elastic/eui/pull/7313)) - Fixed `EuiDataGrid` cells visually cutting off overflowing content a little too quickly ([#7320](https://github.com/elastic/eui/pull/7320)) **Deprecations** - Deprecated `EuiBasicTable` and `EuiInMemoryTable`'s ref `setSelection` API. Use the new `selection.selected` API instead. ([#7321](https://github.com/elastic/eui/pull/7321)) **Breaking changes** - Removed `EuiPageTemplate_Deprecated`, `EuiPageSideBar_Deprecated`, and `EuiPageContent*_Deprecated` ([#7265](https://github.com/elastic/eui/pull/7265)) - Removed the `ghost` color option from `EuiButton`, `EuiButtonEmpty`, and `EuiButtonIcon`. Use an `` wrapper and `color="text"` instead. ([#7296](https://github.com/elastic/eui/pull/7296)) **Dependency updates** - Updated `refractor` to v3.6.0 ([#7127](https://github.com/elastic/eui/pull/7127)) - Updated `rehype-raw` to v5.1.0 ([#7127](https://github.com/elastic/eui/pull/7127)) - Updated `vfile` to v4.2.1 ([#7127](https://github.com/elastic/eui/pull/7127)) **Accessibility** - `EuiContextMenu` now correctly respects reduced motion preferences ([#7312](https://github.com/elastic/eui/pull/7312)) - `EuiAccordion`s no longer attempt to focus child content when the accordion is externally opened via `forceState`, but will continue to focus expanded content when users click the toggle button. ([#7314](https://github.com/elastic/eui/pull/7314)) **CSS-in-JS conversions** - Converted `EuiContextMenu`, `EuiContextMenuPanel`, and `EuiContextMenuItem` to Emotion; Removed `$euiContextMenuWidth` ([#7312](https://github.com/elastic/eui/pull/7312)) --- package.json | 2 +- .../project_navigation_service.test.ts | 6 +- .../fatal_errors_screen.test.tsx.snap | 1 - .../__snapshots__/i18n_service.test.tsx.snap | 6 +- .../src/i18n_eui_mapping.tsx | 12 +- .../__snapshots__/comments.test.tsx.snap | 16 +- ...erate_linked_rules_menu_item.test.tsx.snap | 150 +++---- .../__snapshots__/header_menu.test.tsx.snap | 42 +- .../__snapshots__/list_header.test.tsx.snap | 62 ++- .../__snapshots__/menu_items.test.tsx.snap | 124 +++--- .../field_list_filters/field_type_filter.tsx | 7 +- .../src/user_profiles_popover.test.tsx | 5 +- .../components/line_style_settings.tsx | 89 ++-- .../no_data_card.component.test.tsx.snap | 6 - src/dev/license_checker/config.ts | 2 +- .../time_slider/components/time_slider.tsx | 2 +- .../__snapshots__/indices_list.test.tsx.snap | 12 +- .../color/__snapshots__/color.test.tsx.snap | 3 - .../__snapshots__/static_lookup.test.tsx.snap | 2 - .../table/__snapshots__/table.test.tsx.snap | 2 - .../__snapshots__/add_filter.test.tsx.snap | 4 - .../open_search_panel.test.tsx.snap | 2 - .../__snapshots__/add_data.test.tsx.snap | 2 - .../__snapshots__/footer.test.js.snap | 2 - .../instruction_set.test.js.snap | 10 - .../saved_objects_installer.test.js.snap | 2 - .../__snapshots__/controls_tab.test.tsx.snap | 2 - .../input_control_vis.test.tsx.snap | 8 - .../public/submit_error_callout.test.tsx | 6 - .../elastic_agent_card.test.tsx.snap | 10 - .../top_nav_menu_item.test.tsx.snap | 1 - .../saved_object_save_modal.test.tsx.snap | 8 - .../finder/saved_object_finder.test.tsx | 11 +- .../__snapshots__/flyout.test.tsx.snap | 2 - .../__snapshots__/table.test.tsx.snap | 10 - .../share_context_menu.test.tsx.snap | 15 +- .../__snapshots__/app.test.tsx.snap | 2 +- .../shareable_runtime/components/app.test.tsx | 4 +- .../__snapshots__/settings.test.tsx.snap | 388 ++++++++---------- .../footer/settings/settings.test.tsx | 8 +- .../shareable_runtime/test/interactions.ts | 2 +- .../shareable_runtime/test/selectors.ts | 2 +- .../components/all_cases/use_actions.test.tsx | 8 +- .../all_cases/use_bulk_actions.test.tsx | 8 +- .../follower_indices_list.test.js | 12 +- .../__jest__/policy_table.test.tsx | 2 +- .../home/index_templates_tab.helpers.ts | 4 +- .../__jest__/components/index_table.test.js | 2 +- .../helpers/pipelines_list.helpers.ts | 2 +- .../pipeline_editor.test.js.snap | 24 -- .../pipelines_table.test.js.snap | 2 - .../custom_icon_modal.test.tsx.snap | 5 - .../geometry_filter_form.test.js.snap | 2 - .../add_tooltip_field_popover.test.tsx.snap | 2 - .../features_tooltip/features_tooltip.tsx | 19 +- .../__snapshots__/layer_control.test.tsx.snap | 4 - .../toc_entry_actions_popover.test.tsx.snap | 18 +- .../__snapshots__/tools_control.test.tsx.snap | 7 +- .../rule_editor_flyout.test.js.snap | 6 - .../validate_job_view.test.js.snap | 3 - .../__snapshots__/calendar_form.test.js.snap | 4 - .../__snapshots__/events_table.test.js.snap | 2 - .../__snapshots__/import_modal.test.js.snap | 2 - .../table/__snapshots__/table.test.js.snap | 1 - .../add_item_popover.test.js.snap | 6 - .../delete_filter_list_modal.test.js.snap | 5 - .../edit_filter_list.test.js.snap | 16 - .../flyout/__snapshots__/flyout.test.js.snap | 10 - .../__snapshots__/login_page.test.tsx.snap | 4 - .../__snapshots__/login_form.test.tsx.snap | 3 - .../public/assistant/get_comments/index.tsx | 18 +- .../__snapshots__/index.test.tsx.snap | 4 - .../upgrade_contents.test.tsx.snap | 4 - .../modal_all_errors.test.tsx.snap | 2 - .../__snapshots__/index.test.tsx.snap | 2 - .../take_action_dropdown/index.test.tsx | 2 +- .../__snapshots__/index.test.tsx.snap | 2 +- ...ndex_patterns_missing_prompt.test.tsx.snap | 1 - .../components/resolve_all_conflicts.test.tsx | 2 +- .../delete_spaces_button.test.tsx.snap | 1 - .../manage_spaces_button.test.tsx.snap | 1 - .../components/rule_status_panel.test.tsx | 10 +- .../checklist_step.test.tsx.snap | 1 - .../__snapshots__/warning_step.test.tsx.snap | 1 - .../add_filter_btn.test.tsx | 6 +- .../observability_log_explorer.ts | 7 +- .../services/ml/data_frame_analytics_table.ts | 2 +- .../services/ml/data_visualizer_table.ts | 4 +- .../cypress/screens/exceptions.ts | 2 +- yarn.lock | 56 ++- 90 files changed, 524 insertions(+), 839 deletions(-) diff --git a/package.json b/package.json index 6d8284bae86b..9af2ce5973b3 100644 --- a/package.json +++ b/package.json @@ -102,7 +102,7 @@ "@elastic/datemath": "5.0.3", "@elastic/elasticsearch": "npm:@elastic/elasticsearch-canary@8.9.1-canary.1", "@elastic/ems-client": "8.5.0", - "@elastic/eui": "89.1.0", + "@elastic/eui": "90.0.0", "@elastic/filesaver": "1.1.2", "@elastic/node-crypto": "1.2.1", "@elastic/numeral": "^2.5.1", diff --git a/packages/core/chrome/core-chrome-browser-internal/src/project_navigation/project_navigation_service.test.ts b/packages/core/chrome/core-chrome-browser-internal/src/project_navigation/project_navigation_service.test.ts index 7e1347f8534c..e42176bc177e 100644 --- a/packages/core/chrome/core-chrome-browser-internal/src/project_navigation/project_navigation_service.test.ts +++ b/packages/core/chrome/core-chrome-browser-internal/src/project_navigation/project_navigation_service.test.ts @@ -86,7 +86,7 @@ describe('breadcrumbs', () => { expect(breadcrumbs).toMatchInlineSnapshot(` Array [ Object { - "popoverContent": { expect(breadcrumbs).toMatchInlineSnapshot(` Array [ Object { - "popoverContent": { expect(breadcrumbs).toMatchInlineSnapshot(` Array [ Object { - "popoverContent": { 'euiCollapsibleNavBeta.ariaLabel': i18n.translate('core.euiCollapsibleNavBeta.ariaLabel', { defaultMessage: 'Site menu', }), + 'euiCollapsibleNavButton.ariaLabelExpand': i18n.translate( + 'core.euiCollapsibleNavButton.ariaLabelExpand', + { defaultMessage: 'Expand navigation' } + ), + 'euiCollapsibleNavButton.ariaLabelCollapse': i18n.translate( + 'core.euiCollapsibleNavButton.ariaLabelCollapse', + { defaultMessage: 'Collapse navigation' } + ), 'euiCollapsibleNavButton.ariaLabelClose': i18n.translate( 'core.euiCollapsibleNavButton.ariaLabelClose', - { defaultMessage: 'Toggle navigation closed' } + { defaultMessage: 'Close navigation' } ), 'euiCollapsibleNavButton.ariaLabelOpen': i18n.translate( 'core.euiCollapsibleNavButton.ariaLabelOpen', - { defaultMessage: 'Toggle navigation open' } + { defaultMessage: 'Open navigation' } ), 'euiColorPicker.alphaLabel': i18n.translate('core.euiColorPicker.alphaLabel', { defaultMessage: 'Alpha channel (opacity) value', diff --git a/packages/kbn-securitysolution-exception-list-components/src/exception_item_card/comments/__snapshots__/comments.test.tsx.snap b/packages/kbn-securitysolution-exception-list-components/src/exception_item_card/comments/__snapshots__/comments.test.tsx.snap index 3520fe5a52f2..ff7dddd2da95 100644 --- a/packages/kbn-securitysolution-exception-list-components/src/exception_item_card/comments/__snapshots__/comments.test.tsx.snap +++ b/packages/kbn-securitysolution-exception-list-components/src/exception_item_card/comments/__snapshots__/comments.test.tsx.snap @@ -143,7 +143,7 @@ Object { class="emotion-euiTimelineItemEvent-top" >
    - -
    - , - "container":
    -
    +
    + , + "container":
    +
    + +
    +
    + +
    +
    + +
    +
    - +
    , "debug": [Function], "findAllByAltText": [Function], @@ -146,71 +136,61 @@ Object { "asFragment": [Function], "baseElement":
    -
    - +
    , "container":
    -
    - +
    , "debug": [Function], "findAllByAltText": [Function], diff --git a/packages/kbn-securitysolution-exception-list-components/src/header_menu/__snapshots__/header_menu.test.tsx.snap b/packages/kbn-securitysolution-exception-list-components/src/header_menu/__snapshots__/header_menu.test.tsx.snap index e1a5f056b2e1..dae6c0523600 100644 --- a/packages/kbn-securitysolution-exception-list-components/src/header_menu/__snapshots__/header_menu.test.tsx.snap +++ b/packages/kbn-securitysolution-exception-list-components/src/header_menu/__snapshots__/header_menu.test.tsx.snap @@ -176,50 +176,42 @@ Object {

    diff --git a/packages/kbn-securitysolution-exception-list-components/src/list_header/__snapshots__/list_header.test.tsx.snap b/packages/kbn-securitysolution-exception-list-components/src/list_header/__snapshots__/list_header.test.tsx.snap index dd0778bf5ad8..a458aa90dbed 100644 --- a/packages/kbn-securitysolution-exception-list-components/src/list_header/__snapshots__/list_header.test.tsx.snap +++ b/packages/kbn-securitysolution-exception-list-components/src/list_header/__snapshots__/list_header.test.tsx.snap @@ -1845,71 +1845,59 @@ Object {

    diff --git a/packages/kbn-securitysolution-exception-list-components/src/list_header/menu_items/__snapshots__/menu_items.test.tsx.snap b/packages/kbn-securitysolution-exception-list-components/src/list_header/menu_items/__snapshots__/menu_items.test.tsx.snap index 4427a5c74a5b..90c90a4f3eea 100644 --- a/packages/kbn-securitysolution-exception-list-components/src/list_header/menu_items/__snapshots__/menu_items.test.tsx.snap +++ b/packages/kbn-securitysolution-exception-list-components/src/list_header/menu_items/__snapshots__/menu_items.test.tsx.snap @@ -497,69 +497,57 @@ Object {

    @@ -796,71 +784,59 @@ Object {

    diff --git a/packages/kbn-unified-field-list/src/components/field_list_filters/field_type_filter.tsx b/packages/kbn-unified-field-list/src/components/field_list_filters/field_type_filter.tsx index 7179d326841a..c80b924333ec 100644 --- a/packages/kbn-unified-field-list/src/components/field_list_filters/field_type_filter.tsx +++ b/packages/kbn-unified-field-list/src/components/field_list_filters/field_type_filter.tsx @@ -107,12 +107,7 @@ export function FieldTypeFilter({ const itemStyle = useMemo( () => css` font-size: ${euiTheme.size.m}; - - // Specificity needed to override Sass styles - // EUI TODO: Remove this selector once EuiContextMenu has been converted to Emotion - &.euiContextMenuItem { - padding: ${euiTheme.size.s} ${euiTheme.size.m}; - } + padding: ${euiTheme.size.s} ${euiTheme.size.m}; & + & { border-top: 1px solid ${euiTheme.colors.lightestShade}; diff --git a/packages/kbn-user-profile-components/src/user_profiles_popover.test.tsx b/packages/kbn-user-profile-components/src/user_profiles_popover.test.tsx index 7c1c137740cd..c2b36c39f695 100644 --- a/packages/kbn-user-profile-components/src/user_profiles_popover.test.tsx +++ b/packages/kbn-user-profile-components/src/user_profiles_popover.test.tsx @@ -86,8 +86,7 @@ describe('UserProfilesPopover', () => { panelPaddingSize="none" repositionToCrossAxis={true} > - { ] } /> - + `); }); diff --git a/packages/kbn-visualization-ui-components/components/line_style_settings.tsx b/packages/kbn-visualization-ui-components/components/line_style_settings.tsx index 83315113648b..0151e85004d7 100644 --- a/packages/kbn-visualization-ui-components/components/line_style_settings.tsx +++ b/packages/kbn-visualization-ui-components/components/line_style_settings.tsx @@ -6,7 +6,7 @@ * Side Public License, v 1. */ -import React, { useState } from 'react'; +import React, { useState, memo, useCallback } from 'react'; import { i18n } from '@kbn/i18n'; import { EuiButtonGroup, @@ -44,9 +44,12 @@ export const LineStyleSettings = ({ { + // Without this memoization, EuiFieldNumber rerenders too often + // which somehow causes the annotation query to fall out of sync + onChange={useCallback((value) => { setConfig({ lineWidth: value }); - }} + // eslint-disable-next-line react-hooks/exhaustive-deps + }, [])} /> @@ -107,46 +110,42 @@ function getSafeValue(value: number | '', prevValue: number, min: number, max: n return Math.max(minRange, Math.min(value, maxRange)); } -const LineThicknessSlider = ({ - value, - onChange, -}: { - value: number; - onChange: (value: number) => void; -}) => { - const [unsafeValue, setUnsafeValue] = useState(String(value)); +const LineThicknessSlider = memo( + ({ value, onChange }: { value: number; onChange: (value: number) => void }) => { + const [unsafeValue, setUnsafeValue] = useState(String(value)); - return ( - { - setUnsafeValue(newValue); - const convertedValue = newValue === '' ? '' : Number(newValue); - const safeValue = getSafeValue(Number(newValue), Number(newValue), minRange, maxRange); - // only update onChange is the value is valid and in range - if (convertedValue === safeValue) { - onChange(safeValue); - } - }} - onBlur={() => { - if (unsafeValue !== String(value)) { - const safeValue = getSafeValue( - unsafeValue === '' ? unsafeValue : Number(unsafeValue), - value, - minRange, - maxRange - ); - onChange(safeValue); - setUnsafeValue(String(safeValue)); - } - }} - /> - ); -}; + return ( + { + setUnsafeValue(newValue); + const convertedValue = newValue === '' ? '' : Number(newValue); + const safeValue = getSafeValue(Number(newValue), Number(newValue), minRange, maxRange); + // only update onChange is the value is valid and in range + if (convertedValue === safeValue) { + onChange(safeValue); + } + }} + onBlur={() => { + if (unsafeValue !== String(value)) { + const safeValue = getSafeValue( + unsafeValue === '' ? unsafeValue : Number(unsafeValue), + value, + minRange, + maxRange + ); + onChange(safeValue); + setUnsafeValue(String(safeValue)); + } + }} + /> + ); + } +); diff --git a/packages/shared-ux/card/no_data/impl/src/__snapshots__/no_data_card.component.test.tsx.snap b/packages/shared-ux/card/no_data/impl/src/__snapshots__/no_data_card.component.test.tsx.snap index a74b8433433c..17eb4ef8804c 100644 --- a/packages/shared-ux/card/no_data/impl/src/__snapshots__/no_data_card.component.test.tsx.snap +++ b/packages/shared-ux/card/no_data/impl/src/__snapshots__/no_data_card.component.test.tsx.snap @@ -11,9 +11,7 @@ exports[`NoDataCardComponent props button 1`] = ` description="Use Elastic Agent for a simple, unified way to collect data from your machines." footer={ Button @@ -42,9 +40,7 @@ exports[`NoDataCardComponent props href 1`] = ` description="Use Elastic Agent for a simple, unified way to collect data from your machines." footer={ Add Elastic Agent @@ -74,9 +70,7 @@ exports[`NoDataCardComponent renders 1`] = ` description="Use Elastic Agent for a simple, unified way to collect data from your machines." footer={ Add Elastic Agent diff --git a/src/dev/license_checker/config.ts b/src/dev/license_checker/config.ts index edd363015761..3646fe3ab65d 100644 --- a/src/dev/license_checker/config.ts +++ b/src/dev/license_checker/config.ts @@ -85,7 +85,7 @@ export const LICENSE_OVERRIDES = { 'jsts@1.6.2': ['Eclipse Distribution License - v 1.0'], // cf. https://github.com/bjornharrtell/jsts '@mapbox/jsonlint-lines-primitives@2.0.2': ['MIT'], // license in readme https://github.com/tmcw/jsonlint '@elastic/ems-client@8.5.0': ['Elastic License 2.0'], - '@elastic/eui@89.1.0': ['SSPL-1.0 OR Elastic License 2.0'], + '@elastic/eui@90.0.0': ['SSPL-1.0 OR Elastic License 2.0'], 'language-subtag-registry@0.3.21': ['CC-BY-4.0'], // retired ODC‑By license https://github.com/mattcg/language-subtag-registry 'buffers@0.1.1': ['MIT'], // license in importing module https://www.npmjs.com/package/binary }; diff --git a/src/plugins/controls/public/time_slider/components/time_slider.tsx b/src/plugins/controls/public/time_slider/components/time_slider.tsx index 9bcfc4bc84e4..b236a42c509b 100644 --- a/src/plugins/controls/public/time_slider/components/time_slider.tsx +++ b/src/plugins/controls/public/time_slider/components/time_slider.tsx @@ -43,7 +43,7 @@ export const TimeSlider: FC = (props: Props) => { const rangeRef = useRef(null); - const onPanelResize = (width?: number) => { + const onPanelResize = (width: number) => { rangeRef.current?.onResize(width); }; diff --git a/src/plugins/data_view_editor/public/components/preview_panel/indices_list/__snapshots__/indices_list.test.tsx.snap b/src/plugins/data_view_editor/public/components/preview_panel/indices_list/__snapshots__/indices_list.test.tsx.snap index 52d424c00283..992880eb75c7 100644 --- a/src/plugins/data_view_editor/public/components/preview_panel/indices_list/__snapshots__/indices_list.test.tsx.snap +++ b/src/plugins/data_view_editor/public/components/preview_panel/indices_list/__snapshots__/indices_list.test.tsx.snap @@ -65,7 +65,7 @@ exports[`IndicesList should change pages 1`] = ` panelPaddingSize="none" repositionToCrossAxis={true} > - - - - - - launch myapp diff --git a/src/plugins/home/public/application/components/tutorial/__snapshots__/instruction_set.test.js.snap b/src/plugins/home/public/application/components/tutorial/__snapshots__/instruction_set.test.js.snap index 03609aebc36e..5235392121ab 100644 --- a/src/plugins/home/public/application/components/tutorial/__snapshots__/instruction_set.test.js.snap +++ b/src/plugins/home/public/application/components/tutorial/__snapshots__/instruction_set.test.js.snap @@ -191,10 +191,8 @@ exports[`statusCheckState checking status 1`] = ` size="s" /> custom btn label @@ -307,10 +305,8 @@ exports[`statusCheckState failed status check - error 1`] = ` size="s" /> custom btn label @@ -432,10 +428,8 @@ exports[`statusCheckState failed status check - no data 1`] = ` size="s" /> custom btn label @@ -557,10 +551,8 @@ exports[`statusCheckState initial state - no check has been attempted 1`] = ` size="s" /> custom btn label @@ -673,10 +665,8 @@ exports[`statusCheckState successful status check 1`] = ` size="s" /> custom btn label diff --git a/src/plugins/home/public/application/components/tutorial/__snapshots__/saved_objects_installer.test.js.snap b/src/plugins/home/public/application/components/tutorial/__snapshots__/saved_objects_installer.test.js.snap index f26b49ebf657..c7d07fd394ba 100644 --- a/src/plugins/home/public/application/components/tutorial/__snapshots__/saved_objects_installer.test.js.snap +++ b/src/plugins/home/public/application/components/tutorial/__snapshots__/saved_objects_installer.test.js.snap @@ -138,11 +138,9 @@ exports[`renders 1`] = ` grow={false} > Load Kibana objects diff --git a/src/plugins/input_control_vis/public/components/editor/__snapshots__/controls_tab.test.tsx.snap b/src/plugins/input_control_vis/public/components/editor/__snapshots__/controls_tab.test.tsx.snap index 64fec12d4df4..11a31cd319da 100644 --- a/src/plugins/input_control_vis/public/components/editor/__snapshots__/controls_tab.test.tsx.snap +++ b/src/plugins/input_control_vis/public/components/editor/__snapshots__/controls_tab.test.tsx.snap @@ -169,12 +169,10 @@ exports[`renders ControlsTab 1`] = ` > { } > { } > { } > Button @@ -67,9 +65,7 @@ exports[`ElasticAgentCard props category 1`] = ` description="Use Elastic Agent for a simple, unified way to collect data from your machines." footer={ Add Elastic Agent @@ -118,9 +114,7 @@ exports[`ElasticAgentCard props href 1`] = ` description="Use Elastic Agent for a simple, unified way to collect data from your machines." footer={ Button @@ -174,9 +168,7 @@ exports[`ElasticAgentCard props recommended 1`] = ` description="Use Elastic Agent for a simple, unified way to collect data from your machines." footer={ Add Elastic Agent @@ -225,9 +217,7 @@ exports[`ElasticAgentCard renders 1`] = ` description="Use Elastic Agent for a simple, unified way to collect data from your machines." footer={ Add Elastic Agent diff --git a/src/plugins/navigation/public/top_nav_menu/__snapshots__/top_nav_menu_item.test.tsx.snap b/src/plugins/navigation/public/top_nav_menu/__snapshots__/top_nav_menu_item.test.tsx.snap index ab174c6d0010..570699aa0c0e 100644 --- a/src/plugins/navigation/public/top_nav_menu/__snapshots__/top_nav_menu_item.test.tsx.snap +++ b/src/plugins/navigation/public/top_nav_menu/__snapshots__/top_nav_menu_item.test.tsx.snap @@ -2,7 +2,6 @@ exports[`TopNavMenu Should render emphasized item which should be clickable 1`] = ` Save @@ -236,12 +234,10 @@ exports[`SavedObjectSaveModal should render matching snapshot when custom isVali grow={false} > Save @@ -362,12 +358,10 @@ exports[`SavedObjectSaveModal should render matching snapshot when custom isVali grow={false} > Save @@ -502,12 +496,10 @@ exports[`SavedObjectSaveModal should render matching snapshot when given options grow={false} > Save diff --git a/src/plugins/saved_objects_finder/public/finder/saved_object_finder.test.tsx b/src/plugins/saved_objects_finder/public/finder/saved_object_finder.test.tsx index f02517e845ed..8ac5715263e3 100644 --- a/src/plugins/saved_objects_finder/public/finder/saved_object_finder.test.tsx +++ b/src/plugins/saved_objects_finder/public/finder/saved_object_finder.test.tsx @@ -203,18 +203,13 @@ describe('SavedObjectsFinder', () => { await nextTick(); const searchBar = wrapper.find(EuiInMemoryTable).prop('search') as EuiSearchBarProps; const toolsLeft = searchBar!.toolsLeft; - expect(toolsLeft).toMatchInlineSnapshot( - ` + expect(toolsLeft).toMatchInlineSnapshot(` - + Hello - ` - ); + `); }); }); diff --git a/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/flyout.test.tsx.snap b/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/flyout.test.tsx.snap index 930d657bfc42..7d4ed131f6ea 100644 --- a/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/flyout.test.tsx.snap +++ b/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/flyout.test.tsx.snap @@ -143,7 +143,6 @@ exports[`Flyout conflicts should allow conflict resolution 1`] = ` grow={false} > - `; exports[`shareContextMenuExtensions should sort ascending on sort order first and then ascending on name 1`] = ` - `; exports[`should disable the share URL when set 1`] = ` - `; exports[`should only render permalink panel when there are no other panels 1`] = ` - `; exports[`should render context menu panel when there are more than one panel 1`] = ` - `; diff --git a/x-pack/plugins/canvas/shareable_runtime/components/__snapshots__/app.test.tsx.snap b/x-pack/plugins/canvas/shareable_runtime/components/__snapshots__/app.test.tsx.snap index 5932b2418e8c..5d2efe2903bf 100644 --- a/x-pack/plugins/canvas/shareable_runtime/components/__snapshots__/app.test.tsx.snap +++ b/x-pack/plugins/canvas/shareable_runtime/components/__snapshots__/app.test.tsx.snap @@ -1,3 +1,3 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP -exports[` App renders properly 1`] = `"
    markdown mock
    markdown mock

    Page level controls

    My Canvas Workpad

    There is a new region landmark with page level controls at the end of the document.

    "`; +exports[` App renders properly 1`] = `"
    markdown mock
    markdown mock

    Page level controls

    My Canvas Workpad

    There is a new region landmark with page level controls at the end of the document.

    "`; diff --git a/x-pack/plugins/canvas/shareable_runtime/components/app.test.tsx b/x-pack/plugins/canvas/shareable_runtime/components/app.test.tsx index acf71cad3f3b..ec4ea09e8fcc 100644 --- a/x-pack/plugins/canvas/shareable_runtime/components/app.test.tsx +++ b/x-pack/plugins/canvas/shareable_runtime/components/app.test.tsx @@ -103,7 +103,7 @@ describe('', () => { test('autohide footer functions on mouseEnter + Leave', async () => { const wrapper = getWrapper(); await openSettings(wrapper); - await selectMenuItem(wrapper, 1); + await selectMenuItem(wrapper, 2); expect(footer(wrapper).prop('isHidden')).toEqual(false); expect(footer(wrapper).prop('isAutohide')).toEqual(false); @@ -122,7 +122,7 @@ describe('', () => { // Open the menu and activate toolbar hiding. await openSettings(wrapper); - await selectMenuItem(wrapper, 1); + await selectMenuItem(wrapper, 2); toolbarCheck(wrapper).simulate('click'); await tick(20); diff --git a/x-pack/plugins/canvas/shareable_runtime/components/footer/settings/__snapshots__/settings.test.tsx.snap b/x-pack/plugins/canvas/shareable_runtime/components/footer/settings/__snapshots__/settings.test.tsx.snap index 276dbe72c8be..db2b294c9074 100644 --- a/x-pack/plugins/canvas/shareable_runtime/components/footer/settings/__snapshots__/settings.test.tsx.snap +++ b/x-pack/plugins/canvas/shareable_runtime/components/footer/settings/__snapshots__/settings.test.tsx.snap @@ -28,68 +28,61 @@ exports[` can navigate Autoplay Settings 1`] = `

    Settings
    @@ -129,92 +122,82 @@ exports[` can navigate Autoplay Settings 2`] = `

    Settings
    @@ -381,68 +364,61 @@ exports[` can navigate Toolbar Settings, closes when activated 1`] =

    Settings
    @@ -482,92 +458,82 @@ exports[` can navigate Toolbar Settings, closes when activated 2`] =

    Settings
    @@ -668,92 +634,82 @@ exports[` can navigate Toolbar Settings, closes when activated 3`] =

    Settings
    diff --git a/x-pack/plugins/canvas/shareable_runtime/components/footer/settings/settings.test.tsx b/x-pack/plugins/canvas/shareable_runtime/components/footer/settings/settings.test.tsx index 22a79ecc16aa..cc275dd983e3 100644 --- a/x-pack/plugins/canvas/shareable_runtime/components/footer/settings/settings.test.tsx +++ b/x-pack/plugins/canvas/shareable_runtime/components/footer/settings/settings.test.tsx @@ -52,8 +52,8 @@ describe('', () => { trigger(wrapper).simulate('click'); expect(portal(wrapper).exists()).toEqual(true); expect(popover(wrapper).prop('isOpen')).toEqual(true); - expect(menuItems(wrapper).length).toEqual(2); - expect(contextMenu(wrapper).text()).toEqual('SettingsAuto PlayToolbar'); + expect(menuItems(wrapper).length).toEqual(3); + expect(contextMenu(wrapper).last().text()).toEqual('SettingsAuto PlayToolbar'); trigger(wrapper).simulate('click'); expect(popover(wrapper).prop('isOpen')).toEqual(false); }); @@ -62,7 +62,7 @@ describe('', () => { await openSettings(wrapper); expect(takeMountedSnapshot(portal(wrapper))).toMatchSnapshot(); - await selectMenuItem(wrapper, 0); + await selectMenuItem(wrapper, 1); expect(takeMountedSnapshot(portal(wrapper))).toMatchSnapshot(); }); @@ -70,7 +70,7 @@ describe('', () => { await openSettings(wrapper); expect(takeMountedSnapshot(portal(wrapper))).toMatchSnapshot(); - await selectMenuItem(wrapper, 1); + await selectMenuItem(wrapper, 2); expect(takeMountedSnapshot(portal(wrapper))).toMatchSnapshot(); // Click the Hide Toolbar switch diff --git a/x-pack/plugins/canvas/shareable_runtime/test/interactions.ts b/x-pack/plugins/canvas/shareable_runtime/test/interactions.ts index 1c4b0697f6a1..a9abd5749b7d 100644 --- a/x-pack/plugins/canvas/shareable_runtime/test/interactions.ts +++ b/x-pack/plugins/canvas/shareable_runtime/test/interactions.ts @@ -31,7 +31,7 @@ export const selectMenuItem = async function (wrapper: ReactWrapper, menuItemInd // When the menu item is clicked, wait for all of the context menus to be there await waitFor(() => { wrapper.update(); - return getPortal(wrapper).find('EuiContextMenuPanel').length === 2; + return getPortal(wrapper).find('div.euiContextMenuPanel').length === 2; }); } catch (e) { throw new Error('Context menu did not transition'); diff --git a/x-pack/plugins/canvas/shareable_runtime/test/selectors.ts b/x-pack/plugins/canvas/shareable_runtime/test/selectors.ts index cb625015f634..bcfe94adf94b 100644 --- a/x-pack/plugins/canvas/shareable_runtime/test/selectors.ts +++ b/x-pack/plugins/canvas/shareable_runtime/test/selectors.ts @@ -44,7 +44,7 @@ export const getPopover = (wrapper: ReactWrapper) => wrapper.find('EuiPopover'); export const getPortal = (wrapper: ReactWrapper) => wrapper.find('EuiPortal'); -export const getContextMenu = (wrapper: ReactWrapper) => wrapper.find('EuiContextMenu'); +export const getContextMenu = (wrapper: ReactWrapper) => wrapper.find('EuiContextMenuClass'); export const getContextMenuItems = (wrapper: ReactWrapper) => wrapper.find('EuiContextMenuItem'); diff --git a/x-pack/plugins/cases/public/components/all_cases/use_actions.test.tsx b/x-pack/plugins/cases/public/components/all_cases/use_actions.test.tsx index ab719466bbb2..0efc7a586289 100644 --- a/x-pack/plugins/cases/public/components/all_cases/use_actions.test.tsx +++ b/x-pack/plugins/cases/public/components/all_cases/use_actions.test.tsx @@ -103,7 +103,9 @@ describe('useActions', () => { expect(res.getByTestId('cases-bulk-action-status-closed')).toBeInTheDocument(); }); - userEvent.click(res.getByTestId('cases-bulk-action-status-in-progress')); + userEvent.click(res.getByTestId('cases-bulk-action-status-in-progress'), undefined, { + skipPointerEventsCheck: true, + }); await waitFor(() => { expect(updateCasesSpy).toHaveBeenCalled(); @@ -137,7 +139,9 @@ describe('useActions', () => { expect(res.getByTestId('cases-bulk-action-severity-critical')).toBeInTheDocument(); }); - userEvent.click(res.getByTestId('cases-bulk-action-severity-medium')); + userEvent.click(res.getByTestId('cases-bulk-action-severity-medium'), undefined, { + skipPointerEventsCheck: true, + }); await waitFor(() => { expect(updateCasesSpy).toHaveBeenCalled(); diff --git a/x-pack/plugins/cases/public/components/all_cases/use_bulk_actions.test.tsx b/x-pack/plugins/cases/public/components/all_cases/use_bulk_actions.test.tsx index 3b36a4f3b177..e80813a217ff 100644 --- a/x-pack/plugins/cases/public/components/all_cases/use_bulk_actions.test.tsx +++ b/x-pack/plugins/cases/public/components/all_cases/use_bulk_actions.test.tsx @@ -213,7 +213,9 @@ describe('useBulkActions', () => { expect(res.getByTestId('cases-bulk-action-status-closed')).toBeInTheDocument(); }); - userEvent.click(res.getByTestId('cases-bulk-action-status-in-progress')); + userEvent.click(res.getByTestId('cases-bulk-action-status-in-progress'), undefined, { + skipPointerEventsCheck: true, + }); await waitForHook(() => { expect(updateCasesSpy).toHaveBeenCalled(); @@ -249,7 +251,9 @@ describe('useBulkActions', () => { expect(res.getByTestId('cases-bulk-action-severity-critical')).toBeInTheDocument(); }); - userEvent.click(res.getByTestId('cases-bulk-action-severity-medium')); + userEvent.click(res.getByTestId('cases-bulk-action-severity-medium'), undefined, { + skipPointerEventsCheck: true, + }); await waitForHook(() => { expect(updateCasesSpy).toHaveBeenCalled(); diff --git a/x-pack/plugins/cross_cluster_replication/public/__jest__/client_integration/follower_indices_list.test.js b/x-pack/plugins/cross_cluster_replication/public/__jest__/client_integration/follower_indices_list.test.js index dd62cafd3b95..e020950668a8 100644 --- a/x-pack/plugins/cross_cluster_replication/public/__jest__/client_integration/follower_indices_list.test.js +++ b/x-pack/plugins/cross_cluster_replication/public/__jest__/client_integration/follower_indices_list.test.js @@ -228,19 +228,19 @@ describe('', () => { describe('table row action menu', () => { test('should open a context menu when clicking on the button of each row', async () => { - expect(component.find('.euiContextMenuPanel').length).toBe(0); + expect(component.find('div.euiContextMenuPanel').length).toBe(0); await actions.openTableRowContextMenuAt(0); - expect(component.find('.euiContextMenuPanel').length).toBe(1); + expect(component.find('div.euiContextMenuPanel').length).toBe(1); }); test('should have the "pause", "edit" and "unfollow" options in the row context menu', async () => { await actions.openTableRowContextMenuAt(0); const buttonLabels = component - .find('.euiContextMenuPanel') - .find('.euiContextMenuItem') + .find('div.euiContextMenuPanel') + .find('button.euiContextMenuItem') .map((button) => button.text()); expect(buttonLabels).toEqual([ @@ -255,8 +255,8 @@ describe('', () => { await actions.openTableRowContextMenuAt(1); const buttonLabels = component - .find('.euiContextMenuPanel') - .find('.euiContextMenuItem') + .find('div.euiContextMenuPanel') + .find('button.euiContextMenuItem') .map((button) => button.text()); expect(buttonLabels).toEqual([ diff --git a/x-pack/plugins/index_lifecycle_management/__jest__/policy_table.test.tsx b/x-pack/plugins/index_lifecycle_management/__jest__/policy_table.test.tsx index 891bb347d5a2..7c28270dd419 100644 --- a/x-pack/plugins/index_lifecycle_management/__jest__/policy_table.test.tsx +++ b/x-pack/plugins/index_lifecycle_management/__jest__/policy_table.test.tsx @@ -163,7 +163,7 @@ describe('policy table', () => { const perPageButton = rendered.find('EuiTablePagination EuiPopover').find('button'); perPageButton.simulate('click'); rendered.update(); - const numberOfRowsButton = rendered.find('.euiContextMenuItem').at(1); + const numberOfRowsButton = rendered.find('button.euiContextMenuItem').at(1); numberOfRowsButton.simulate('click'); rendered.update(); expect(getPolicyNames(rendered).length).toBe(25); diff --git a/x-pack/plugins/index_management/__jest__/client_integration/home/index_templates_tab.helpers.ts b/x-pack/plugins/index_management/__jest__/client_integration/home/index_templates_tab.helpers.ts index e992ff4e3b58..c8e58aa6875f 100644 --- a/x-pack/plugins/index_management/__jest__/client_integration/home/index_templates_tab.helpers.ts +++ b/x-pack/plugins/index_management/__jest__/client_integration/home/index_templates_tab.helpers.ts @@ -34,7 +34,7 @@ const createActions = (testBed: TestBed) => { const actions = ['edit', 'clone', 'delete']; const { component } = testBed; - return component.find('.euiContextMenuItem').at(actions.indexOf(action)); + return component.find('button.euiContextMenuItem').at(actions.indexOf(action)); }; /** @@ -77,7 +77,7 @@ const createActions = (testBed: TestBed) => { clickActionMenu(templateName); act(() => { - component.find('.euiContextMenuItem').at(actions.indexOf(action)).simulate('click'); + component.find('button.euiContextMenuItem').at(actions.indexOf(action)).simulate('click'); }); component.update(); }; diff --git a/x-pack/plugins/index_management/__jest__/components/index_table.test.js b/x-pack/plugins/index_management/__jest__/components/index_table.test.js index 90656b16b33e..a3e0dd01f250 100644 --- a/x-pack/plugins/index_management/__jest__/components/index_table.test.js +++ b/x-pack/plugins/index_management/__jest__/components/index_table.test.js @@ -212,7 +212,7 @@ describe('index table', () => { perPageButton.simulate('click'); rendered.update(); - const fiftyButton = rendered.find('.euiContextMenuItem').at(1); + const fiftyButton = rendered.find('button.euiContextMenuItem').at(1); fiftyButton.simulate('click'); rendered.update(); expect(namesText(rendered).length).toBe(50); diff --git a/x-pack/plugins/ingest_pipelines/__jest__/client_integration/helpers/pipelines_list.helpers.ts b/x-pack/plugins/ingest_pipelines/__jest__/client_integration/helpers/pipelines_list.helpers.ts index 19de9b825310..a06dab8a0969 100644 --- a/x-pack/plugins/ingest_pipelines/__jest__/client_integration/helpers/pipelines_list.helpers.ts +++ b/x-pack/plugins/ingest_pipelines/__jest__/client_integration/helpers/pipelines_list.helpers.ts @@ -74,7 +74,7 @@ const createActions = (testBed: TestBed) => { clickActionMenu(pipelineName); act(() => { - component.find('.euiContextMenuItem').at(actions.indexOf(action)).simulate('click'); + component.find('button.euiContextMenuItem').at(actions.indexOf(action)).simulate('click'); }); component.update(); diff --git a/x-pack/plugins/logstash/public/application/components/pipeline_editor/__snapshots__/pipeline_editor.test.js.snap b/x-pack/plugins/logstash/public/application/components/pipeline_editor/__snapshots__/pipeline_editor.test.js.snap index f635f810d1ca..35b59d233cd2 100644 --- a/x-pack/plugins/logstash/public/application/components/pipeline_editor/__snapshots__/pipeline_editor.test.js.snap +++ b/x-pack/plugins/logstash/public/application/components/pipeline_editor/__snapshots__/pipeline_editor.test.js.snap @@ -258,12 +258,10 @@ Default value: 1024" grow={false} > Delete @@ -207,12 +206,10 @@ exports[`should render a custom icon modal with an existing icon 1`] = ` grow={false} > Save @@ -289,12 +286,10 @@ exports[`should render an empty custom icon modal 1`] = ` grow={false} > Save diff --git a/x-pack/plugins/maps/public/components/draw_forms/geometry_filter_form/__snapshots__/geometry_filter_form.test.js.snap b/x-pack/plugins/maps/public/components/draw_forms/geometry_filter_form/__snapshots__/geometry_filter_form.test.js.snap index c092f90dd721..6714a7779f90 100644 --- a/x-pack/plugins/maps/public/components/draw_forms/geometry_filter_form/__snapshots__/geometry_filter_form.test.js.snap +++ b/x-pack/plugins/maps/public/components/draw_forms/geometry_filter_form/__snapshots__/geometry_filter_form.test.js.snap @@ -57,7 +57,6 @@ exports[`render 1`] = ` textAlign="right" > { _renderBackButton(label: string) { return ( - + {label} + ); } diff --git a/x-pack/plugins/maps/public/connected_components/right_side_controls/layer_control/__snapshots__/layer_control.test.tsx.snap b/x-pack/plugins/maps/public/connected_components/right_side_controls/layer_control/__snapshots__/layer_control.test.tsx.snap index 71a4053d105c..73da1b32f60e 100644 --- a/x-pack/plugins/maps/public/connected_components/right_side_controls/layer_control/__snapshots__/layer_control.test.tsx.snap +++ b/x-pack/plugins/maps/public/connected_components/right_side_controls/layer_control/__snapshots__/layer_control.test.tsx.snap @@ -97,13 +97,11 @@ exports[`LayerControl is rendered 1`] = ` /> - @@ -163,7 +162,7 @@ exports[`TOCEntryActionsPopover should disable Edit features when edit mode acti panelPaddingSize="none" repositionToCrossAxis={true} > - @@ -280,7 +278,7 @@ exports[`TOCEntryActionsPopover should disable fit to data when supportsFitToBou panelPaddingSize="none" repositionToCrossAxis={true} > - @@ -398,7 +395,7 @@ exports[`TOCEntryActionsPopover should have "show layer" action when layer is no panelPaddingSize="none" repositionToCrossAxis={true} > - @@ -515,7 +511,7 @@ exports[`TOCEntryActionsPopover should not show edit actions in read only mode 1 panelPaddingSize="none" repositionToCrossAxis={true} > - @@ -601,7 +596,7 @@ exports[`TOCEntryActionsPopover should show "show this layer only" action when t panelPaddingSize="none" repositionToCrossAxis={true} > - diff --git a/x-pack/plugins/maps/public/connected_components/toolbar_overlay/tools_control/__snapshots__/tools_control.test.tsx.snap b/x-pack/plugins/maps/public/connected_components/toolbar_overlay/tools_control/__snapshots__/tools_control.test.tsx.snap index 0a65eaec8529..a342861bea94 100644 --- a/x-pack/plugins/maps/public/connected_components/toolbar_overlay/tools_control/__snapshots__/tools_control.test.tsx.snap +++ b/x-pack/plugins/maps/public/connected_components/toolbar_overlay/tools_control/__snapshots__/tools_control.test.tsx.snap @@ -34,7 +34,7 @@ exports[`Should render cancel button when drawing 1`] = ` panelPaddingSize="none" repositionToCrossAxis={true} > - - `; diff --git a/x-pack/plugins/ml/public/application/components/rule_editor/__snapshots__/rule_editor_flyout.test.js.snap b/x-pack/plugins/ml/public/application/components/rule_editor/__snapshots__/rule_editor_flyout.test.js.snap index a5bf2b49835c..f790d70b0bc8 100644 --- a/x-pack/plugins/ml/public/application/components/rule_editor/__snapshots__/rule_editor_flyout.test.js.snap +++ b/x-pack/plugins/ml/public/application/components/rule_editor/__snapshots__/rule_editor_flyout.test.js.snap @@ -232,11 +232,9 @@ exports[`RuleEditorFlyout renders the flyout after adding a condition to a rule grow={false} >
    , Next @@ -399,13 +397,11 @@ exports[`Flyout beats part one should render normally 1`] = ` grow={false} > Next @@ -775,13 +771,11 @@ exports[`Flyout elasticsearch part one should render normally 1`] = ` grow={false} > Next @@ -1112,13 +1106,11 @@ exports[`Flyout kibana part one should render normally 1`] = ` grow={false} > Next @@ -1456,13 +1448,11 @@ exports[`Flyout logstash part one should render normally 1`] = ` grow={false} > Next diff --git a/x-pack/plugins/security/public/authentication/login/__snapshots__/login_page.test.tsx.snap b/x-pack/plugins/security/public/authentication/login/__snapshots__/login_page.test.tsx.snap index 169c246316e6..4c6d1d66a8b9 100644 --- a/x-pack/plugins/security/public/authentication/login/__snapshots__/login_page.test.tsx.snap +++ b/x-pack/plugins/security/public/authentication/login/__snapshots__/login_page.test.tsx.snap @@ -23,12 +23,10 @@ exports[`LoginPage disabled form states renders CTA and browser settings warning Do Something @@ -58,10 +56,8 @@ exports[`EmptyPage component renders actions without descriptions 1`] = ` } > Do Something diff --git a/x-pack/plugins/security_solution/public/common/components/ml_popover/__snapshots__/upgrade_contents.test.tsx.snap b/x-pack/plugins/security_solution/public/common/components/ml_popover/__snapshots__/upgrade_contents.test.tsx.snap index dbe80300221d..40b509ae683f 100644 --- a/x-pack/plugins/security_solution/public/common/components/ml_popover/__snapshots__/upgrade_contents.test.tsx.snap +++ b/x-pack/plugins/security_solution/public/common/components/ml_popover/__snapshots__/upgrade_contents.test.tsx.snap @@ -38,11 +38,9 @@ exports[`JobsTableFilters renders correctly against snapshot 1`] = ` grow={false} > Subscription plans @@ -52,10 +50,8 @@ exports[`JobsTableFilters renders correctly against snapshot 1`] = ` grow={false} > Manage license diff --git a/x-pack/plugins/security_solution/public/common/components/toasters/__snapshots__/modal_all_errors.test.tsx.snap b/x-pack/plugins/security_solution/public/common/components/toasters/__snapshots__/modal_all_errors.test.tsx.snap index 5b2483821fcb..452f598b9ed6 100644 --- a/x-pack/plugins/security_solution/public/common/components/toasters/__snapshots__/modal_all_errors.test.tsx.snap +++ b/x-pack/plugins/security_solution/public/common/components/toasters/__snapshots__/modal_all_errors.test.tsx.snap @@ -33,11 +33,9 @@ exports[`Modal all errors rendering it renders the default all errors modal when Close diff --git a/x-pack/plugins/security_solution/public/detections/components/rules/next_step/__snapshots__/index.test.tsx.snap b/x-pack/plugins/security_solution/public/detections/components/rules/next_step/__snapshots__/index.test.tsx.snap index 035910b32526..433b38773c14 100644 --- a/x-pack/plugins/security_solution/public/detections/components/rules/next_step/__snapshots__/index.test.tsx.snap +++ b/x-pack/plugins/security_solution/public/detections/components/rules/next_step/__snapshots__/index.test.tsx.snap @@ -15,12 +15,10 @@ exports[`NextStep renders correctly against snapshot 1`] = ` grow={false} > Continue diff --git a/x-pack/plugins/security_solution/public/detections/components/take_action_dropdown/index.test.tsx b/x-pack/plugins/security_solution/public/detections/components/take_action_dropdown/index.test.tsx index d342092dd3d9..356938a6d54e 100644 --- a/x-pack/plugins/security_solution/public/detections/components/take_action_dropdown/index.test.tsx +++ b/x-pack/plugins/security_solution/public/detections/components/take_action_dropdown/index.test.tsx @@ -340,7 +340,7 @@ describe('take action dropdown', () => { wrapper.find('button[data-test-subj="take-action-dropdown-btn"]').simulate('click'); await waitFor(() => { expect( - wrapper.find('[data-test-subj="add-event-filter-menu-item"]').first().getDOMNode() + wrapper.find('[data-test-subj="add-event-filter-menu-item"]').last().getDOMNode() ).toBeEnabled(); }); }); diff --git a/x-pack/plugins/security_solution/public/explore/components/paginated_table/__snapshots__/index.test.tsx.snap b/x-pack/plugins/security_solution/public/explore/components/paginated_table/__snapshots__/index.test.tsx.snap index 81640e156f2a..720e9f86acf8 100644 --- a/x-pack/plugins/security_solution/public/explore/components/paginated_table/__snapshots__/index.test.tsx.snap +++ b/x-pack/plugins/security_solution/public/explore/components/paginated_table/__snapshots__/index.test.tsx.snap @@ -117,7 +117,7 @@ exports[`Paginated Table Component rendering it renders the default load more ta repositionOnScroll={true} repositionToCrossAxis={true} > - Configure index patterns diff --git a/x-pack/plugins/spaces/public/copy_saved_objects_to_space/components/resolve_all_conflicts.test.tsx b/x-pack/plugins/spaces/public/copy_saved_objects_to_space/components/resolve_all_conflicts.test.tsx index 1d0780d3451f..4f5fc04d88be 100644 --- a/x-pack/plugins/spaces/public/copy_saved_objects_to_space/components/resolve_all_conflicts.test.tsx +++ b/x-pack/plugins/spaces/public/copy_saved_objects_to_space/components/resolve_all_conflicts.test.tsx @@ -109,7 +109,7 @@ describe('ResolveAllConflicts', () => { panelPaddingSize="none" repositionToCrossAxis={true} > - { await act(async () => { const actionsMenuElem = wrapper.find('[data-test-subj="ruleStatusMenu"]'); - const actionsMenuItemElem = actionsMenuElem.first().find('.euiContextMenuItem'); + const actionsMenuItemElem = actionsMenuElem.first().find('button.euiContextMenuItem'); actionsMenuItemElem.at(1).simulate('click'); await nextTick(); }); @@ -160,7 +160,7 @@ describe('rule status panel', () => { await act(async () => { const actionsMenuElem = wrapper.find('[data-test-subj="ruleStatusMenu"]'); - const actionsMenuItemElem = actionsMenuElem.first().find('.euiContextMenuItem'); + const actionsMenuItemElem = actionsMenuElem.first().find('button.euiContextMenuItem'); actionsMenuItemElem.at(1).simulate('click'); await nextTick(); }); @@ -192,7 +192,7 @@ describe('rule status panel', () => { await act(async () => { const actionsMenuElem = wrapper.find('[data-test-subj="ruleStatusMenu"]'); - const actionsMenuItemElem = actionsMenuElem.first().find('.euiContextMenuItem'); + const actionsMenuItemElem = actionsMenuElem.first().find('button.euiContextMenuItem'); actionsMenuItemElem.at(0).simulate('click'); await nextTick(); }); @@ -226,7 +226,7 @@ describe('rule status panel', () => { await act(async () => { const actionsMenuElem = wrapper.find('[data-test-subj="ruleStatusMenu"]'); - const actionsMenuItemElem = actionsMenuElem.first().find('.euiContextMenuItem'); + const actionsMenuItemElem = actionsMenuElem.first().find('button.euiContextMenuItem'); actionsMenuItemElem.at(0).simulate('click'); await nextTick(); }); @@ -267,7 +267,7 @@ describe('rule status panel', () => { await act(async () => { const actionsMenuElem = wrapper.find('[data-test-subj="ruleStatusMenu"]'); - const actionsMenuItemElem = actionsMenuElem.first().find('.euiContextMenuItem'); + const actionsMenuItemElem = actionsMenuElem.first().find('button.euiContextMenuItem'); actionsMenuItemElem.at(1).simulate('click'); }); diff --git a/x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/deprecation_types/reindex/flyout/__snapshots__/checklist_step.test.tsx.snap b/x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/deprecation_types/reindex/flyout/__snapshots__/checklist_step.test.tsx.snap index 9157f6dab0f5..ef7942942562 100644 --- a/x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/deprecation_types/reindex/flyout/__snapshots__/checklist_step.test.tsx.snap +++ b/x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/deprecation_types/reindex/flyout/__snapshots__/checklist_step.test.tsx.snap @@ -78,7 +78,6 @@ exports[`ChecklistFlyout renders 1`] = ` fill={true} isLoading={false} onClick={[MockFunction]} - size="m" > { panelPaddingSize="none" repositionToCrossAxis={true} > - { panelPaddingSize="none" repositionToCrossAxis={true} > - { panelPaddingSize="none" repositionToCrossAxis={true} > - diff --git a/x-pack/test/functional/page_objects/observability_log_explorer.ts b/x-pack/test/functional/page_objects/observability_log_explorer.ts index 1804ae95ddc9..2978e3205f46 100644 --- a/x-pack/test/functional/page_objects/observability_log_explorer.ts +++ b/x-pack/test/functional/page_objects/observability_log_explorer.ts @@ -268,7 +268,7 @@ export function ObservabilityLogExplorerPageObject({ }, getPanelTitle(contextMenu: WebElementWrapper) { - return contextMenu.findByClassName('euiContextMenuPanelTitle'); + return contextMenu.findByClassName('euiContextMenuPanel__title'); }, async getDatasetSelectorButtonText() { @@ -277,7 +277,10 @@ export function ObservabilityLogExplorerPageObject({ }, getPanelEntries(contextMenu: WebElementWrapper) { - return contextMenu.findAllByCssSelector('.euiContextMenuItem:not([disabled])', 2000); + return contextMenu.findAllByCssSelector( + 'button.euiContextMenuItem:not([disabled]):not([data-test-subj="contextMenuPanelTitleButton"])', + 2000 + ); }, getAllLogDatasetsButton() { diff --git a/x-pack/test/functional/services/ml/data_frame_analytics_table.ts b/x-pack/test/functional/services/ml/data_frame_analytics_table.ts index 33b79d9d7967..2b89364644a3 100644 --- a/x-pack/test/functional/services/ml/data_frame_analytics_table.ts +++ b/x-pack/test/functional/services/ml/data_frame_analytics_table.ts @@ -275,7 +275,7 @@ export function MachineLearningDataFrameAnalyticsTableProvider({ public async assertJobActionViewButtonEnabled(analyticsId: string, expectedValue: boolean) { await this.ensureJobActionsMenuOpen(analyticsId); const actionMenuViewButton = await find.byCssSelector( - '[data-test-subj="mlAnalyticsJobViewButton"][class="euiContextMenuItem"]' + '.euiContextMenuItem[data-test-subj="mlAnalyticsJobViewButton"]' ); const isEnabled = await actionMenuViewButton.isEnabled(); expect(isEnabled).to.eql( diff --git a/x-pack/test/functional/services/ml/data_visualizer_table.ts b/x-pack/test/functional/services/ml/data_visualizer_table.ts index ac6b1309d1d3..1ad3efd90aa5 100644 --- a/x-pack/test/functional/services/ml/data_visualizer_table.ts +++ b/x-pack/test/functional/services/ml/data_visualizer_table.ts @@ -182,7 +182,7 @@ export function MachineLearningDataVisualizerTableProvider( await retry.tryForTime(30 * 1000, async () => { await this.ensureActionsMenuOpen(fieldName); const actionMenuViewInLensButton = await find.byCssSelector( - '[data-test-subj="dataVisualizerActionViewInLensButton"][class="euiContextMenuItem"]' + '.euiContextMenuItem[data-test-subj="dataVisualizerActionViewInLensButton"]' ); const isEnabled = await actionMenuViewInLensButton.isEnabled(); expect(isEnabled).to.eql( @@ -217,7 +217,7 @@ export function MachineLearningDataVisualizerTableProvider( await this.ensureActionsMenuOpen(fieldName); const button = await find.byCssSelector( - `[data-test-subj="${testSubj}"][class="euiContextMenuItem"]` + `.euiContextMenuItem[data-test-subj="${testSubj}"]` ); await button.click(); await this.assertActionsMenuClosed(fieldName, testSubj); diff --git a/x-pack/test/security_solution_cypress/cypress/screens/exceptions.ts b/x-pack/test/security_solution_cypress/cypress/screens/exceptions.ts index dc7cbb4b08df..f93e01271fda 100644 --- a/x-pack/test/security_solution_cypress/cypress/screens/exceptions.ts +++ b/x-pack/test/security_solution_cypress/cypress/screens/exceptions.ts @@ -243,7 +243,7 @@ export const EXCEPTION_LIST_DETAIL_LINKED_TO_RULES_HEADER_MENU = '[data-test-subj="exceptionListManagementRightSideMenuItemsLinkedRulesMenuEmptyButton"]'; export const EXCEPTION_LIST_DETAIL_LINKED_TO_RULES_HEADER_MENU_ITEM = - '[data-test-subj="exceptionListManagementRightSideMenuItemsLinkedRulesMenuMenuPanel"] div button'; + '[data-test-subj="exceptionListManagementRightSideMenuItemsLinkedRulesMenuMenuPanel"] .euiContextMenuItem'; export const EXCEPTION_LIST_DETAIL_MENU_ITEMS = '[data-test-subj="exceptionListManagementRightSideMenuItemsMenuActionsButtonIcon"]'; diff --git a/yarn.lock b/yarn.lock index 8228e70e0730..74de368eff69 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1594,10 +1594,10 @@ resolved "https://registry.yarnpkg.com/@elastic/eslint-plugin-eui/-/eslint-plugin-eui-0.0.2.tgz#56b9ef03984a05cc213772ae3713ea8ef47b0314" integrity sha512-IoxURM5zraoQ7C8f+mJb9HYSENiZGgRVcG4tLQxE61yHNNRDXtGDWTZh8N1KIHcsqN1CEPETjuzBXkJYF/fDiQ== -"@elastic/eui@89.1.0": - version "89.1.0" - resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-89.1.0.tgz#25aa9a59515102221286780ab559c3cff91a3753" - integrity sha512-vvSfP+kMUeQlfmxnRZhdX7r3rxpmjc3PkWC0KrMTf+NlXEao1imvlMHJNIJ58z5YjUBSMN5jtXkNkjHGI86KDw== +"@elastic/eui@90.0.0": + version "90.0.0" + resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-90.0.0.tgz#f105576513ed2fb31fefab5e1287be4e090ba0f3" + integrity sha512-4LXY4CwXU3FHeOiW76VPTaYcPVKEiqpb8GGHFEkYfBPWBgXyUJUVJyXwX9k8pzXElxM9I68OTDVRxIUzEzFiug== dependencies: "@hello-pangea/dnd" "^16.3.0" "@types/lodash" "^4.14.198" @@ -1618,8 +1618,8 @@ react-remove-scroll-bar "^2.3.4" react-virtualized-auto-sizer "^1.0.20" react-window "^1.8.9" - refractor "^3.5.0" - rehype-raw "^5.0.0" + refractor "^3.6.0" + rehype-raw "^5.1.0" rehype-react "^6.2.1" rehype-stringify "^8.0.0" remark-breaks "^2.0.2" @@ -1632,7 +1632,7 @@ unist-util-visit "^2.0.3" url-parse "^1.5.10" uuid "^8.3.0" - vfile "^4.2.0" + vfile "^4.2.1" "@elastic/filesaver@1.1.2": version "1.1.2" @@ -17924,7 +17924,7 @@ hast-util-parse-selector@^2.0.0, hast-util-parse-selector@^2.2.0: resolved "https://registry.yarnpkg.com/hast-util-parse-selector/-/hast-util-parse-selector-2.2.3.tgz#57edd449103900c7f63fd9e6f694ffd7e4634719" integrity sha512-nxbeqjQNxsvo/uYYAw9kij6td05YVUlf1qti09rVfbWSLT5H6wo3c+USIwX6nzXWk5kFZzXnEqO82856r0aM2Q== -hast-util-raw@6.0.1, hast-util-raw@^6.0.0: +hast-util-raw@6.0.1: version "6.0.1" resolved "https://registry.yarnpkg.com/hast-util-raw/-/hast-util-raw-6.0.1.tgz#973b15930b7529a7b66984c98148b46526885977" integrity sha512-ZMuiYA+UF7BXBtsTBNcLBF5HzXzkyE6MLzJnL605LKE8GJylNjGc4jjxazAHUtcwT5/CEt6afRKViYB4X66dig== @@ -17940,6 +17940,23 @@ hast-util-raw@6.0.1, hast-util-raw@^6.0.0: xtend "^4.0.0" zwitch "^1.0.0" +hast-util-raw@^6.1.0: + version "6.1.0" + resolved "https://registry.yarnpkg.com/hast-util-raw/-/hast-util-raw-6.1.0.tgz#e16a3c2642f65cc7c480c165400a40d604ab75d0" + integrity sha512-5FoZLDHBpka20OlZZ4I/+RBw5piVQ8iI1doEvffQhx5CbCyTtP8UCq8Tw6NmTAMtXgsQxmhW7Ly8OdFre5/YMQ== + dependencies: + "@types/hast" "^2.0.0" + hast-util-from-parse5 "^6.0.0" + hast-util-to-parse5 "^6.0.0" + html-void-elements "^1.0.0" + parse5 "^6.0.0" + unist-util-position "^3.0.0" + unist-util-visit "^2.0.0" + vfile "^4.0.0" + web-namespaces "^1.0.0" + xtend "^4.0.0" + zwitch "^1.0.0" + hast-util-to-html@^7.1.1: version "7.1.1" resolved "https://registry.yarnpkg.com/hast-util-to-html/-/hast-util-to-html-7.1.1.tgz#39818b8bbfcb8eaa87846a120b3875487b27d094" @@ -25887,7 +25904,7 @@ redux@^4.0.0, redux@^4.0.4, redux@^4.1.2, redux@^4.2.0: dependencies: "@babel/runtime" "^7.9.2" -refractor@^3.2.0, refractor@^3.5.0: +refractor@^3.2.0, refractor@^3.6.0: version "3.6.0" resolved "https://registry.yarnpkg.com/refractor/-/refractor-3.6.0.tgz#ac318f5a0715ead790fcfb0c71f4dd83d977935a" integrity sha512-MY9W41IOWxxk31o+YvFCNyNzdkc9M20NoZK5vq6jkv4I/uh2zkWcfudj0Q1fovjUQJrNewS9NMzeTtqPf+n5EA== @@ -26005,12 +26022,12 @@ regjsparser@^0.8.2: dependencies: jsesc "~0.5.0" -rehype-raw@^5.0.0: - version "5.0.0" - resolved "https://registry.yarnpkg.com/rehype-raw/-/rehype-raw-5.0.0.tgz#3688e3e1132e958761e677a1b9b2ba358a465af8" - integrity sha512-q/MOBj4fs1WF/LSCh5uOtNhnm5OESuDcSvq1mDQP4/2t6Q52E9MHeVoLeMy9vOn93BEcgVBm4FCokcK2iXRDvA== +rehype-raw@^5.1.0: + version "5.1.0" + resolved "https://registry.yarnpkg.com/rehype-raw/-/rehype-raw-5.1.0.tgz#66d5e8d7188ada2d31bc137bc19a1000cf2c6b7e" + integrity sha512-MDvHAb/5mUnif2R+0IPCYJU8WjHa9UzGtM/F4AVy5GixPlDZ1z3HacYy4xojDU+uBa+0X/3PIfyQI26/2ljJNA== dependencies: - hast-util-raw "^6.0.0" + hast-util-raw "^6.1.0" rehype-react@^6.2.1: version "6.2.1" @@ -26236,7 +26253,7 @@ repeating@^2.0.0: dependencies: is-finite "^1.0.0" -replace-ext@1.0.0, replace-ext@^1.0.0: +replace-ext@^1.0.0: version "1.0.0" resolved "https://registry.yarnpkg.com/replace-ext/-/replace-ext-1.0.0.tgz#de63128373fcbf7c3ccfa4de5a480c45a67958eb" integrity sha1-3mMSg3P8v3w8z6TeWkgMRaZ5WOs= @@ -30199,14 +30216,13 @@ vfile-message@^2.0.0: "@types/unist" "^2.0.0" unist-util-stringify-position "^2.0.0" -vfile@^4.0.0, vfile@^4.2.0: - version "4.2.0" - resolved "https://registry.yarnpkg.com/vfile/-/vfile-4.2.0.tgz#26c78ac92eb70816b01d4565e003b7e65a2a0e01" - integrity sha512-a/alcwCvtuc8OX92rqqo7PflxiCgXRFjdyoGVuYV+qbgCb0GgZJRvIgCD4+U/Kl1yhaRsaTwksF88xbPyGsgpw== +vfile@^4.0.0, vfile@^4.2.1: + version "4.2.1" + resolved "https://registry.yarnpkg.com/vfile/-/vfile-4.2.1.tgz#03f1dce28fc625c625bc6514350fbdb00fa9e624" + integrity sha512-O6AE4OskCG5S1emQ/4gl8zK586RqA3srz3nfK/Viy0UPToBc5Trp9BVFb1u0CjsKrAWwnpr4ifM/KBXPWwJbCA== dependencies: "@types/unist" "^2.0.0" is-buffer "^2.0.0" - replace-ext "1.0.0" unist-util-stringify-position "^2.0.0" vfile-message "^2.0.0"