Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EUI Refresh] A weight has been lifted... #7942

Closed
wants to merge 6 commits into from
Closed

Conversation

ryankeairns
Copy link
Contributor

@ryankeairns ryankeairns commented Aug 2, 2024

Summary

Goal

Reduce the dominant headings in Elastic product UIs.

Problem

The current ‘Amsterdam’ EUI theme has been around for several years and brings with it large, heavy-weighted headings of prior trends. As a result, page titles, modals, flyouts, and tabs - to name a few components - can eat up a relatively large amount of screen real estate while also being visually loud.

Project stakeholders

Design proposals

Both near-term and long-term changes are based upon design work from the EUI Refresh project.

Near-term

Make this iterative change to reduce the topmost font sizes and font weights in EUI.

  • Reducing the topmost font sizes primarily affects titles which appear atop pages, modals, and flyouts.
  • Reducing the topmost font weights affects all headings (h1-h6) which appear in many more places such as cards, dashboard panels, tabs, etc.

🔬Preview typography changes (this PR) in Kibana


Sample before and after from EUI docs

CleanShot 2024-09-05 at 13 57 06@2x

Sample before and after from Kibana test environment

→ More side-by-side Kibana comparisons can be found in this Figma file

CleanShot 2024-09-05 at 13 58 16@2x

Longer-term

TBD by the new theme project. Further refinements might include:

  • Introduction of an additional monospace font for visualizations (number values, axes, etc.)
  • Reduce the overall number of text styles provided by EuiText
  • On the Kibana side, evaluate the usage of larger size/titles (more semantic; less large)

Implementation notes

Changes would be made directly to EUI - in alignment with new theme efforts - and are not expected to produce many, if any, downstream impacts to product teams. Once merged, the changes would be applied via the next EUI upgrade of Kibana.

We would proactively inform teams of the pending change to reduce potential surprise or questions once the changes land.

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately.
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist
    • If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

@ryankeairns ryankeairns self-assigned this Aug 5, 2024
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @ryankeairns

@ryankeairns
Copy link
Contributor Author

I will chat with @yanwalton about the gates we need to clear to get this approved and merged.

@kyrspl
Copy link
Contributor

kyrspl commented Sep 30, 2024

These changes will be integrated with phase 1 changes aimed at Kibana 9.0 release (as part of the new theme)

@mgadewoll
Copy link
Contributor

mgadewoll commented Sep 30, 2024

ℹ️ We're going to implement the changes as part of this task.

@ryankeairns
Copy link
Contributor Author

Shall I close this PR then?

@ryankeairns
Copy link
Contributor Author

These changes will be integrated with phase 1 changes aimed at Kibana 9.0 release (as part of the new theme)

@cee-chen cee-chen deleted the rk/de-chonk-titles branch September 30, 2024 16:53
@JasonStoltz JasonStoltz restored the rk/de-chonk-titles branch October 18, 2024 14:59
@JasonStoltz
Copy link
Member

Spinning up a new test instance so resurrected this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants