Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y] [VPAT] 1.3.1 Info and Relationships - Search > Dev Tools - Tab groups should be a single Tab stop, traversed via arrow keys #8005

Open
dave-gus opened this issue Sep 5, 2024 · 1 comment · May be fixed by #8116
Assignees
Labels
accessibility low hanging fruit An issue, often a bug, that is lower effort and clearly ought to be fixed

Comments

@dave-gus
Copy link

dave-gus commented Sep 5, 2024

Steps to Reproduce:

Pre-requisite:
User has created a Search project and gone to the homepage for that Search project.
Screen reader is activated.

Using keyboard navigation:

  1. In left nav, select 'Dev Tools'
  2. Navigate to tabs in main content (Console/Search Profiler/Grok Debugger)
  3. Tab through the displayed tabs and observe keyboard navigation behavior

Expected Result:

  • User uses tab key to navigate to the group of tabs and then navigates the tabs via arrow keys and selects via Enter/Space Bar. Screen reader informs user that it is a group of tabs and the state (selected, not selected) of each tab.

Actual Result:

  • User uses tab key to navigate the tabs. The state of each tab is not conveyed.

This issue impacts:
1.3.1 Info and Relationships
2.4.3 Focus Order
4.1.2 Name, Role, Value (State is also an aspect of this SC)

WCAG or Vendor Guidance (optional)

@cee-chen
Copy link
Member

cee-chen commented Sep 9, 2024

This is interesting because it essentially gives the tabs the same UX as role="radio", and we recently moved away from that UX for EuiButtonGroup: #7101

EuiTabs feels fairly similar to an EuiButtonGroup in this regard, and I worry a little that since it looks like buttons, it would feel odd that it navigates via arrow keys and not tabs. See also:

That beings said, both MDN and WCAG spec clearly use arrow key navigation:

So we should likely follow the spec 🤷

@JasonStoltz JasonStoltz added the low hanging fruit An issue, often a bug, that is lower effort and clearly ought to be fixed label Sep 17, 2024
@weronikaolejniczak weronikaolejniczak self-assigned this Oct 21, 2024
@weronikaolejniczak weronikaolejniczak linked a pull request Nov 4, 2024 that will close this issue
12 tasks
weronikaolejniczak added a commit to weronikaolejniczak/eui that referenced this issue Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility low hanging fruit An issue, often a bug, that is lower effort and clearly ought to be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants