Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Grid style updates don't cause re-render #7962

Closed
lukasolson opened this issue Aug 13, 2024 · 2 comments · Fixed by #8080
Closed

[DataGrid] Grid style updates don't cause re-render #7962

lukasolson opened this issue Aug 13, 2024 · 2 comments · Fixed by #8080
Assignees

Comments

@lukasolson
Copy link
Member

Describe the bug
CodeSandbox here: https://codesandbox.io/s/quirky-fire-cpj3v7?file=/demo.js

When the DataGrid accepts a gridStyle prop, updates to that prop don't cause the data grid to re-render.

In the above example, if you use the data grid controls to change the density, you'll see the grid re-render in response. However, if you click the button at the top "Reset to Compact", which explicitly sets the grid style to compact, it doesn't re-render (even though you can see the console logging the new grid style):

Screen.Recording.2024-08-13.at.2.32.23.PM.mov

Impact and severity
This isn't currently a big issue, but it was found as part of elastic/kibana#188495 (comment). We will have a workaround for that PR, but it would be nice if this could be fixed so the workaround can be removed.

@lukasolson lukasolson added bug ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible labels Aug 13, 2024
@pamellix
Copy link

@lukasolson I'll try to fix it

@JasonStoltz JasonStoltz removed the ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible label Aug 19, 2024
@JasonStoltz
Copy link
Member

JasonStoltz commented Aug 19, 2024

Thanks ya'll! We've added this to our backlog. We would be super happy to receive a PR for this -- otherwise we'll lump this into some larger Data Grid work we're planning for this quarter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants