Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiSteps unordered variant #7785

Closed
JoseLuisGJ opened this issue May 23, 2024 · 6 comments · Fixed by #7813
Closed

EuiSteps unordered variant #7785

JoseLuisGJ opened this issue May 23, 2024 · 6 comments · Fixed by #7813
Assignees

Comments

@JoseLuisGJ
Copy link
Contributor

JoseLuisGJ commented May 23, 2024

Describe the solution you'd like
I'd like to get a EuiSteps variant where the step number is not required nor displayed performing like a unordered list or unordered step. This approach will fit better with some guided steps that aims for letting users go back and forth between different steps on a less prescriptive proposal.

Describe alternatives you've considered
Alternatively the step prop should be optional and not having a default value to archive this result. But we should also manage the size of the circle somehow for getting a more balanced composition.

Desired timeline
During Jun 2024 ? It'll be used for 8.15 release

Additional context

  • I see that the size of the step number circle container is tight to the titleSize prop. Should we have a way for managing with more precision the size of this circle container as a part of this request?
  • The proposed designs are using a circle container of 12 x 12 pixels whereas the smallesttitleSize = xs is 24px x 24px
  • Should we just let use this unordered variant in xs or xxs sizes? For big sizes might end up with a none balanced composition.
  • I guess that icons should not be allowed within the circle content with this variant due to the container is 12 x 12 and the icons will be smaller than that minim size for icons.

CleanShot 2024-05-20 at 13 24 55@2x
Self managed - Connector selected

@JasonStoltz
Copy link
Member

JasonStoltz commented May 23, 2024

Just making this connection here briefly. We had a proposal for a smaller sized step icons that we considered previously: #6850

That actually proposed "xxs" icons which would inherently be numberless.

This Figma design outlined the proposal: https://www.figma.com/design/RzfYLj2xmH9K7gQtbSKygn/branch/tWvdxSqgrul0pDPHy6oEC0/Elastic-UI?node-id=13460-357&t=7vQOdJNsYG8Gjkew-0

For simplicity, we could just introduce an "xxs" size which is inherently numberless. That would avoid the need to introduce an additional prop to toggle the numberless format or not (but not prevent us from adding it in the future to larger sizes)

@JasonStoltz
Copy link
Member

JasonStoltz commented May 30, 2024

@JasonStoltz
Copy link
Member

JasonStoltz commented May 30, 2024

@JoseLuisGJ For this issue, we discussed only adding a new "xxs" option to steps, which would use a numberless format as detailed in this Figma file: https://www.figma.com/design/RzfYLj2xmH9K7gQtbSKygn/branch/tWvdxSqgrul0pDPHy6oEC0/Elastic-UI?node-id=13460-357&t=38gHxrIJyHjPqpgX-0

Screenshot 2024-05-30 at 9 52 01 AM Screenshot 2024-05-30 at 9 51 52 AM

Would this be sufficient to address your needs?

@JoseLuisGJ
Copy link
Contributor Author

Looks good to me. It will cover our needs so far and overall makes sense to get this special version with the smallest size we can mange. Thanks for addressing this.

@JasonStoltz
Copy link
Member

@JoseLuisGJ We are planning to include this in next week's release. Will that give you enough time to work it into 8.15?

@JoseLuisGJ
Copy link
Contributor Author

It will @JasonStoltz , thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants