Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Use badges for sorting and column controls in toolbar #7283

Closed
Tracked by #168084
jughosta opened this issue Oct 13, 2023 · 4 comments · Fixed by #7369
Closed
Tracked by #168084

[EuiDataGrid] Use badges for sorting and column controls in toolbar #7283

jughosta opened this issue Oct 13, 2023 · 4 comments · Fixed by #7369
Assignees

Comments

@jughosta
Copy link
Contributor

jughosta commented Oct 13, 2023

Pre design we should move counters from left side to right side and style them as badges. This includes showing a badge for the columns control too.

Current:
Screenshot 2023-10-13 at 16 45 30

Proposed:
Screenshot 2023-10-13 at 16 43 55

  • Please note that adding borders as above is not included in this ticket, we update only counters look.
@1Copenut
Copy link
Contributor

Thank you for submitting this @jughosta. The EUI team will discuss it in our grooming session on Monday.

This change will be considered for design and accessibility. Moving the number to the right of the label means the accessible label will change slightly. EUI will follow up if there are questions about labeling.

@JasonStoltz
Copy link
Member

@kertal We discussed as a team, we would accept a PR for this if you'd like to proceed.

@kertal
Copy link
Member

kertal commented Oct 24, 2023

@JasonStoltz thx, can you assign @jughosta, I don't have the permission to do so

@cee-chen
Copy link
Member

Closed by #7369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants