Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-router-dom to latest v5 and cleanup related dependencies usage #6891

Closed
Tracked by #6182
tkajtoch opened this issue Jun 29, 2023 · 0 comments · Fixed by #6892
Closed
Tracked by #6182

Update react-router-dom to latest v5 and cleanup related dependencies usage #6891

tkajtoch opened this issue Jun 29, 2023 · 0 comments · Fixed by #6892
Assignees
Labels
task A task associated with a larger Meta issue

Comments

@tkajtoch
Copy link
Member

We need to update react-router-dom and dependencies related to it to ensure React 18 compatibility and cleanup our code from deprecated usages. This is also a great opportunity for us to remove unused react-router-redux as it's not working since react-router v4 and it hasn't been used in our code for over 3 years.

Acceptance Criteria:

  • react-router-dom is updated to latest v5 version (5.3.4 at the time of creating this issue)
  • @types/react-router-dom is updated to version compatible with the updated react-router-dom
  • react-router is removed and imports are updated to use react-router-dom instead
    • importing from both react-router and react-router-dom can cause router context being null or invalid
  • react-router-redux is removed as it's no longer used or supported by modern react-router versions
  • history is removed in favor of <HashRouter>
@tkajtoch tkajtoch added the task A task associated with a larger Meta issue label Jun 29, 2023
@tkajtoch tkajtoch self-assigned this Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task A task associated with a larger Meta issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant