Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiInlineEdit] Create placeholder prop for Inline Edit compoents #6857

Closed
breehall opened this issue Jun 21, 2023 · 0 comments · Fixed by #6883
Closed

[EuiInlineEdit] Create placeholder prop for Inline Edit compoents #6857

breehall opened this issue Jun 21, 2023 · 0 comments · Fixed by #6883
Assignees
Labels
feature request task A task associated with a larger Meta issue

Comments

@breehall
Copy link
Contributor

breehall commented Jun 21, 2023

Is your feature request related to a problem? Please describe.
The inline edit pattern in Stack Management is similar to the EuiInlineEdit component, however, it has two display options for readMode. It can either:

  • Display a default value that populates the field text form control in editMode
  • Display a placeholder value that does not populate the field text form control in editMode
image

Component Reference: <InlineTextInput />
Path: x-pack/plugins/ingest_pipelines/public/application/components/pipeline_editor/components/pipeline_processors_editor_item/inline_text_input.tsx

Describe the solution you'd like

  • Create a boolean prop to determine if the default value should be displayed as a placeholder or not
  • When the boolean is set to true, the editMode field text value will default to an empty string.
    Consumers will still need to implement validation to ensure that empty values cannot be stored.

Additional context
Related to #6778

@breehall breehall self-assigned this Jun 21, 2023
@cee-chen cee-chen added the task A task associated with a larger Meta issue label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request task A task associated with a larger Meta issue
Projects
None yet
2 participants