-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiDescriptionList] Low contrast in inline
mode
#6856
Comments
@ryankeairns - Here I'm using background-color: ${euiTheme.colors.fullShade};
color: ${euiTheme.colors.ink}; It's the last option in It seems like What do you think? |
🤔 I was envisioning a more subtle (i.e. less contrasting) background color. In other words to use a color that is just a shade or two above the page background color with the text then being light. I have not tested the contrast values of such an approach, but I do wonder about the high contrast white bg value (above) when it is repeated extensively in an area like Discover. Update: it would need some finessing, but #343731 meets the contrast check though it may be too faint |
Here are (1) background-color: ${euiTheme.colors.emptyShade};
color: ${euiTheme.colors.text}; (2) background-color: ${euiTheme.colors.lightestShade};
color: ${euiTheme.colors.text}; (3) background-color: ${euiTheme.colors.lightShade};
color: ${euiTheme.colors.title}; (4) background-color: ${euiTheme.colors.mediumShade};
color: ${euiTheme.colors.title}; (5) background-color: ${euiTheme.colors.darkestShade};
color: ${euiTheme.colors.ink}; |
Thanks for putting these together. I also prefer number (3) @andreadelrio any thoughts from your Discover point of view? |
FYI - once we take the decision I can integrate the change with #7062 |
In Discover, we're getting rid of the background in the |
Thanks for your comments. I've incorporated option (3) in #7062 |
👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed. |
Describe the problem
During a cursory review of dark modes styles in Kibana, I noticed that the
inline
mode ofEuiDescriptionList
does not meet minimum contrast levels. The same WCAG failure can be seen in the EUI docs example as seen below.To Reproduce
Proposed solution
Set the text color on the
dt
totext
color when in dark mode.WCAG or Vendor Guidance (optional)
The text was updated successfully, but these errors were encountered: