Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiDataGrid] Column selector errors when its dependent state briefly de-syncs #3539

Closed
chandlerprall opened this issue Jun 2, 2020 · 1 comment
Closed

[EuiDataGrid] Column selector errors when its dependent state briefly de-syncs #3539

chandlerprall opened this issue Jun 2, 2020 · 1 comment
Labels
bug data grid stale-issue stale-issue-closed

Comments

@chandlerprall
Copy link
Contributor

chandlerprall commented Jun 2, 2020 •
edited
Loading

from #3520 (comment)

column_selector.tsx has to use displayValues[id] || id instead of displayValues[id] right now as a fallback until useDependentState re-syncs the value, as it relies on the post-render useEffect.

eui/src/components/datagrid/column_selector.tsx

Line 202 in d0c497b

label={displayValues[id] || id}

@cchaos cchaos changed the title EuiDataGrid's column selector errors when its dependent state briefly de-syncs [EuiDataGrid] Column selector errors when its dependent state briefly de-syncs Sep 20, 2020
@cee-chen
Copy link
Member

Is this still an issue? I'm not seeing a problem with a || id fallback if displayValues[id] is unavailable for any reason.

@cee-chen cee-chen closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug data grid stale-issue stale-issue-closed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chandlerprall @cee-chen @cchaos