Fix API generator (#4456)

This commit fixes the API generator and removes REST API specs
ported from later version branches:

1. The collection of high level endpoints were being used in some
of the low level generators
2. High level endpoints excluded need to be compared to the list by filename
3. Exclude new ML experimental APIs

Co-authored-by: Stuart Cam <[email protected]>

Author: russcam

src/ApiGenerator/Configuration/CodeConfiguration.cs

@@ -19,6 +19,11 @@ public static class CodeConfiguration
 			"indices.reload_search_analyzers.json",
 			"rank_eval.json",
 			"eql.search.json",
+			"ml.delete_trained_model.json",
+			"ml.get_trained_models.json",
+			"ml.get_trained_models_stats.json",
+			"ml.put_trained_model.json",
+			"ml.explain_data_frame_analytics.json",
 
 			// Internal API,
 			"monitoring.bulk.json",

src/ApiGenerator/Domain/RestApiSpec.cs

@@ -22,13 +22,13 @@ public class RestApiSpec
 
 		public IDictionary<string, ApiEndpoint> Endpoints { get; set; }
 
-		public ImmutableSortedDictionary<string, ReadOnlyCollection<ApiEndpoint>> EndpointsPerNamespace =>
+		public ImmutableSortedDictionary<string, ReadOnlyCollection<ApiEndpoint>> EndpointsPerNamespaceLowLevel =>
 			Endpoints.Values.GroupBy(e=>e.CsharpNames.Namespace)
 				.ToImmutableSortedDictionary(kv => kv.Key, kv => kv.ToList().AsReadOnly());
 
 		public ImmutableSortedDictionary<string, ReadOnlyCollection<ApiEndpoint>> EndpointsPerNamespaceHighLevel =>
 			Endpoints.Values
-				.Where(v => !CodeConfiguration.IgnoredApisHighLevel.Contains(v.Name))
+				.Where(v => !CodeConfiguration.IgnoredApisHighLevel.Contains(v.FileName))
 				.GroupBy(e => e.CsharpNames.Namespace)
 				.ToImmutableSortedDictionary(kv => kv.Key, kv => kv.ToList().AsReadOnly());
 

src/ApiGenerator/Generator/Razor/LowLevelClientImplementationGenerator.cs

@@ -17,7 +17,7 @@ public override async Task Generate(RestApiSpec spec, ProgressBar progressBar)
 			var target = GeneratorLocations.LowLevel($"ElasticLowLevelClient.{CsharpNames.RootNamespace}.cs");
 			await DoRazor(spec, view, target);
 
-			var namespaced = spec.EndpointsPerNamespaceHighLevel.Where(kv => kv.Key != CsharpNames.RootNamespace).ToList();
+			var namespaced = spec.EndpointsPerNamespaceLowLevel.Where(kv => kv.Key != CsharpNames.RootNamespace).ToList();
 			var namespacedView = ViewLocations.LowLevel("Client", "Implementation", "ElasticLowLevelClient.Namespace.cshtml");
 			await DoRazorDependantFiles(progressBar, namespaced, namespacedView, kv => kv.Key,
 				id => GeneratorLocations.LowLevel($"ElasticLowLevelClient.{id}.cs"));

src/ApiGenerator/Generator/Razor/RequestParametersGenerator.cs

@@ -15,7 +15,7 @@ public override async Task Generate(RestApiSpec spec, ProgressBar progressBar)
 			var view = ViewLocations.LowLevel("RequestParameters", "RequestParameters.cshtml");
 			string Target(string id) => GeneratorLocations.LowLevel("Api", "RequestParameters", $"RequestParameters.{id}.cs");
 
-			var namespaced = spec.EndpointsPerNamespaceHighLevel.ToList();
+			var namespaced = spec.EndpointsPerNamespaceLowLevel.ToList();
 			await DoRazorDependantFiles(progressBar, namespaced, view, kv => kv.Key, id => Target(id));
 		}
 	}

src/ApiGenerator/RestSpecification/Core/delete_by_query.json

@@ -41,6 +41,10 @@
       ]
     },
     "params":{
+      "analyzer": {
+        "type" : "string",
+        "description" : "The analyzer to use for the query string"
+      },
       "analyze_wildcard": {
         "type" : "boolean",
         "description" : "Specify whether wildcard and prefix queries should be analyzed (default: false)"

src/ApiGenerator/RestSpecification/Core/msearch_template.json

@@ -70,6 +70,11 @@
         "type" : "boolean",
         "description" : "Indicates whether hits.total should be rendered as an integer or an object in the rest search response",
         "default" : false
+      },
+      "ccs_minimize_roundtrips": {
+        "type" : "boolean",
+        "description" : "Indicates whether network round-trips should be minimized as part of cross-cluster search requests execution",
+        "default" : "true"
       }
     },
     "body":{

src/ApiGenerator/RestSpecification/Core/root.html

@@ -109,6 +109,11 @@
         "type":"boolean",
         "description":"Indicates whether hits.total should be rendered as an integer or an object in the rest search response",
         "default":false
+      },
+      "ccs_minimize_roundtrips": {
+        "type" : "boolean",
+        "description" : "Indicates whether network round-trips should be minimized as part of cross-cluster search requests execution",
+        "default" : "true"
       }
     },
     "body":{