From 2120e6b24181a2a647278e48aa2d83f2c205ba8c Mon Sep 17 00:00:00 2001 From: Martijn Laarman Date: Sun, 2 Feb 2025 20:35:29 +0100 Subject: [PATCH] Add explicit continue-on-error input to the preview workflow --- .github/workflows/preview.yml | 8 +++++++- actions/publish/action.yml | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/preview.yml b/.github/workflows/preview.yml index 4e8503bc..4e55338f 100644 --- a/.github/workflows/preview.yml +++ b/.github/workflows/preview.yml @@ -4,8 +4,14 @@ on: workflow_call: inputs: strict: + description: 'Treat warnings as errors' type: boolean default: true + continue-on-error: + description: 'Do not fail to publish if build fails' + type: boolean + required: false + default: true # default for will be false after migration permissions: id-token: write @@ -62,7 +68,7 @@ jobs: - name: Build documentation if: github.repository != 'elastic/docs-builder' uses: elastic/docs-builder@main - continue-on-error: ${{ inputs.strict != 'true' }} # Will be removed after the migration phase + continue-on-error: ${{ inputs.continue-on-error == 'true' }} # Will be removed after the migration phase with: prefix: "/${{ github.repository }}/pull/${{ github.event.pull_request.number }}" strict: ${{ inputs.strict }} diff --git a/actions/publish/action.yml b/actions/publish/action.yml index df7005d3..a4f2d82f 100644 --- a/actions/publish/action.yml +++ b/actions/publish/action.yml @@ -15,7 +15,7 @@ inputs: description: 'Treat warnings as errors' required: false continue-on-error: - description: 'Treat warnings as errors' + description: 'Do not fail to publish if build fails' required: false default: "false" private: