Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attributes to use md links #324

Closed
1 of 3 tasks
karenzone opened this issue Jan 22, 2025 · 1 comment
Closed
1 of 3 tasks

Update attributes to use md links #324

karenzone opened this issue Jan 22, 2025 · 1 comment
Labels

Comments

@karenzone
Copy link
Contributor

karenzone commented Jan 22, 2025

Describe the bug

The text comes in OK, but the link remains in asciidoctor format.
IIRC, the {{ess-leading-short}}attribute has source tracking embedded in the link. That might be a factor.

Image

Expected behavior

Link would render and resolve correctly.
Bonus points if we can keep our source tracking.

Steps to reproduce

  1. Build the logstash.md doc set
  2. Go to http://localhost:3000/connecting-to-cloud.html

Tooling

  • docs-builder
  • migration tooling
  • I'm not sure
@karenzone karenzone added the bug label Jan 22, 2025
@bmorelli25 bmorelli25 changed the title Text provided by shared attribute not rendering correctly (link format) Update attributes to use md links Jan 23, 2025
@bmorelli25
Copy link
Member

bmorelli25 commented Jan 23, 2025

Changed the title as this is happening because the value for the ess-leadin attr is hard-coded to an asciidoc link

  ess-leadin:   "You can run Elasticsearch on your own hardware or use our hosted Elasticsearch Service that is available on AWS, GCP, and Azure. https://cloud.elastic.co/registration{ess-utm-params}[Try the Elasticsearch Service for free]."

@bmorelli25 bmorelli25 added chore and removed bug labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants