Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images should enlarge on the page #304

Closed
1 of 3 tasks
georgewallace opened this issue Jan 22, 2025 · 1 comment · Fixed by #858
Closed
1 of 3 tasks

Images should enlarge on the page #304

georgewallace opened this issue Jan 22, 2025 · 1 comment · Fixed by #858
Assignees

Comments

@georgewallace
Copy link
Contributor

Describe the bug

On page https://bookish-dollop-9p66716.pages.github.io/common-log-format-example.html

If you click on the following image https://bookish-dollop-9p66716.pages.github.io/images/ingest-pipeline-processor.png. You get a blown up view which is awesome! But then you are stuck!

Image

Expected behavior

I would expect an X or some other control like clicking outside of the image to take me back.

Steps to reproduce

Navigate to https://bookish-dollop-9p66716.pages.github.io/common-log-format-example.html and observe the list and click on any image

Tooling

  • docs-builder
  • migration tooling
  • I'm not sure
@bmorelli25 bmorelli25 changed the title When clicking an image, no way to escape back to page except for back button. Images should enlarge on the page Jan 23, 2025
@bmorelli25
Copy link
Member

Oops, I opened #329 before seeing this. I'll close that issue.

Right now clicking on an image opens the file in the same tab you're viewing the docs in. This enlarges the image, but is annoying because you have to click back to the content you were viewing.

Potential solution

Enlarge images over the content you're viewing so you don't actually leave the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants