Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attributes/Variables not resolved in page titles and in the footer #296

Closed
1 of 3 tasks
szabosteve opened this issue Jan 22, 2025 · 5 comments · Fixed by #458
Closed
1 of 3 tasks

Attributes/Variables not resolved in page titles and in the footer #296

szabosteve opened this issue Jan 22, 2025 · 5 comments · Fixed by #458
Labels
attributes bug

Comments

@szabosteve
Copy link

szabosteve commented Jan 22, 2025 •
edited
Loading

Describe the bug

Former AsciiDoc attributes are not resolved in page titles...

Image

and in the footer.

Image

Expected behavior

Former AsciiDoc attributes should be resolved in page titles and in the footer.

Steps to reproduce

  1. Build the machine-learning.md doc set.
  2. Go to http://localhost:3000/setup.html

Tooling

  • docs-builder
  • migration tooling
  • I'm not sure
@szabosteve szabosteve added the bug label Jan 22, 2025
@szabosteve szabosteve changed the title Attributes/Variables not resolved in page titles Attributes/Variables not resolved in page titles and in the footer Jan 22, 2025
@marciw
Copy link

marciw commented Jan 22, 2025

This is happening in the elasticsearch docs too -- for example, https://bookish-dollop-9p66716.pages.github.io/elasticsearch-intro.html

@karenzone
Copy link
Contributor

Logstash, too.

Image

@bmorelli25
Copy link
Member

Related: #300, #430

@Mpdreamz
Copy link
Member

The footer works (atleast as #458)

Image

@Mpdreamz
Copy link
Member

And h1 headers should now work correctly too:

Image

@Mpdreamz Mpdreamz linked a pull request Feb 10, 2025 that will close this issue
Support variables in table of contents. #458
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
attributes bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support variables in table of contents. elastic/docs-builder
5 participants
@Mpdreamz @marciw @bmorelli25 @szabosteve @karenzone