Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line breaks are rendering as <br> inside of collapsible components #295

Closed
1 of 3 tasks
shainaraskas opened this issue Jan 22, 2025 · 2 comments
Closed
1 of 3 tasks

Comments

@shainaraskas
Copy link

shainaraskas commented Jan 22, 2025

Describe the bug

Line breaks written as + in the old system are being rendered with a plaintext <br> in the new system

Image

raw asciidoc markup:

[[snowball_stemmers_have_been_upgraded]]
.Snowball stemmers have been upgraded
[%collapsible]
====
*Details* +
Lucene 10 ships with an upgrade of its Snowball stemmers.  For details see https://github.com/apache/lucene/issues/13209. Users using Snowball stemmers that are experiencing changes in search behaviour on  existing data are advised to reindex.

*Impact* +
The upgrade should generally provide improved stemming results. Small changes in token analysis can lead to mismatches with previously index data, so existing indices using Snowball stemmers as part of their analysis chain should be reindexed.
====

raw md markup:

::::{dropdown} Snowball stemmers have been upgraded
:name: snowball_stemmers_have_been_upgraded

**Details**<br> Lucene 10 ships with an upgrade of its Snowball stemmers.  For details see [https://github.com/apache/lucene/issues/13209](https://github.com/apache/lucene/issues/13209). Users using Snowball stemmers that are experiencing changes in search behaviour on  existing data are advised to reindex.

**Impact**<br> The upgrade should generally provide improved stemming results. Small changes in token analysis can lead to mismatches with previously index data, so existing indices using Snowball stemmers as part of their analysis chain should be reindexed.

::::

Expected behavior

<br> is replaced with a line break (either in the md file or the frontend)

example of how it looked in the old system:

Image

Steps to reproduce

No response

Tooling

  • docs-builder
  • migration tooling
  • I'm not sure
@georgewallace
Copy link

This is also showing outside of collapsible components. as you can find on https://bookish-dollop-9p66716.pages.github.io/common-log-format-example.html

Image

@bmorelli25
Copy link
Member

Fixed in #342.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants