naming

Author: reakaleek

src/Elastic.Documentation.Site/Assets/web-components/SearchOrAskAi/AskAi/AskAiEvent.ts

@@ -4,8 +4,8 @@ import * as z from 'zod'
 // Event type constants for type-safe referencing
 export const EventTypes = {
     CONVERSATION_START: 'conversation_start',
-    CHUNK: 'chunk',
-    CHUNK_COMPLETE: 'chunk_complete',
+    MESSAGE_CHUNK: 'message_chunk',
+    MESSAGE_COMPLETE: 'message_complete',
     SEARCH_TOOL_CALL: 'search_tool_call',
     TOOL_CALL: 'tool_call',
     TOOL_RESULT: 'tool_result',
@@ -23,14 +23,14 @@ export const ConversationStartEventSchema = z.object({
 })
 
 export const ChunkEventSchema = z.object({
-    type: z.literal(EventTypes.CHUNK),
+    type: z.literal(EventTypes.MESSAGE_CHUNK),
     id: z.string(),
     timestamp: z.number(),
     content: z.string(),
 })
 
 export const ChunkCompleteEventSchema = z.object({
-    type: z.literal(EventTypes.CHUNK_COMPLETE),
+    type: z.literal(EventTypes.MESSAGE_COMPLETE),
     id: z.string(),
     timestamp: z.number(),
     fullContent: z.string(),

src/Elastic.Documentation.Site/Assets/web-components/SearchOrAskAi/AskAi/ChatMessage.tsx

@@ -144,7 +144,7 @@ const computeAiStatus = (
                 m.type === EventTypes.SEARCH_TOOL_CALL ||
                 m.type === EventTypes.TOOL_CALL ||
                 m.type === EventTypes.TOOL_RESULT ||
-                m.type === EventTypes.CHUNK
+                m.type === EventTypes.MESSAGE_CHUNK
         )
         .sort((a, b) => a.timestamp - b.timestamp)
 
@@ -166,9 +166,9 @@ const computeAiStatus = (
         case EventTypes.TOOL_RESULT:
             return STATUS_MESSAGES.ANALYZING
 
-        case EventTypes.CHUNK: {
+        case EventTypes.MESSAGE_CHUNK: {
             const allContent = events
-                .filter((m) => m.type === EventTypes.CHUNK)
+                .filter((m) => m.type === EventTypes.MESSAGE_CHUNK)
                 .map((m) => m.content)
                 .join('')
 

src/Elastic.Documentation.Site/Assets/web-components/SearchOrAskAi/AskAi/StreamingAiMessage.tsx

@@ -35,7 +35,7 @@ export const StreamingAiMessage = ({
                 if (event.conversationId && !threadId) {
                     setThreadId(event.conversationId)
                 }
-            } else if (event.type === EventTypes.CHUNK) {
+            } else if (event.type === EventTypes.MESSAGE_CHUNK) {
                 contentRef.current += event.content
             } else if (event.type === EventTypes.ERROR) {
                 // Handle error events from the stream

src/api/Elastic.Documentation.Api.Core/AskAi/AskAiEvent.cs

@@ -11,8 +11,8 @@ namespace Elastic.Documentation.Api.Core.AskAi;
 /// </summary>
 [JsonPolymorphic(TypeDiscriminatorPropertyName = "type")]
 [JsonDerivedType(typeof(ConversationStart), typeDiscriminator: "conversation_start")]
-[JsonDerivedType(typeof(Chunk), typeDiscriminator: "chunk")]
-[JsonDerivedType(typeof(ChunkComplete), typeDiscriminator: "chunk_complete")]
+[JsonDerivedType(typeof(MessageChunk), typeDiscriminator: "message_chunk")]
+[JsonDerivedType(typeof(MessageComplete), typeDiscriminator: "message_complete")]
 [JsonDerivedType(typeof(SearchToolCall), typeDiscriminator: "search_tool_call")]
 [JsonDerivedType(typeof(ToolCall), typeDiscriminator: "tool_call")]
 [JsonDerivedType(typeof(ToolResult), typeDiscriminator: "tool_result")]
@@ -33,7 +33,7 @@ string ConversationId
 	/// <summary>
 	/// Streaming text chunk from AI
 	/// </summary>
-	public sealed record Chunk(
+	public sealed record MessageChunk(
 		string Id,
 		long Timestamp,
 		string Content
@@ -42,7 +42,7 @@ string Content
 	/// <summary>
 	/// Complete message when streaming is done
 	/// </summary>
-	public sealed record ChunkComplete(
+	public sealed record MessageComplete(
 		string Id,
 		long Timestamp,
 		string FullContent
@@ -111,8 +111,8 @@ string Message
 /// </summary>
 [JsonSerializable(typeof(AskAiEvent))]
 [JsonSerializable(typeof(AskAiEvent.ConversationStart))]
-[JsonSerializable(typeof(AskAiEvent.Chunk))]
-[JsonSerializable(typeof(AskAiEvent.ChunkComplete))]
+[JsonSerializable(typeof(AskAiEvent.MessageChunk))]
+[JsonSerializable(typeof(AskAiEvent.MessageComplete))]
 [JsonSerializable(typeof(AskAiEvent.SearchToolCall))]
 [JsonSerializable(typeof(AskAiEvent.ToolCall))]
 [JsonSerializable(typeof(AskAiEvent.ToolResult))]

src/api/Elastic.Documentation.Api.Infrastructure/Adapters/AskAi/AgentBuilderStreamTransformer.cs

@@ -41,10 +41,10 @@ public class AgentBuilderStreamTransformer(ILogger<AgentBuilderStreamTransformer
 				new AskAiEvent.ConversationStart(id, timestamp, convId.GetString()!),
 
 			"message_chunk" when innerData.TryGetProperty("text_chunk", out var textChunk) =>
-				new AskAiEvent.Chunk(id, timestamp, textChunk.GetString()!),
+				new AskAiEvent.MessageChunk(id, timestamp, textChunk.GetString()!),
 
 			"message_complete" when innerData.TryGetProperty("message_content", out var fullContent) =>
-				new AskAiEvent.ChunkComplete(id, timestamp, fullContent.GetString()!),
+				new AskAiEvent.MessageComplete(id, timestamp, fullContent.GetString()!),
 
 			"reasoning" =>
 				// Parse reasoning message if available

src/api/Elastic.Documentation.Api.Infrastructure/Adapters/AskAi/LlmGatewayStreamTransformer.cs

@@ -41,10 +41,10 @@ public class LlmGatewayStreamTransformer(ILogger<LlmGatewayStreamTransformer> lo
 				new AskAiEvent.ConversationStart(id, timestamp, Guid.NewGuid().ToString()),
 
 			"ai_message_chunk" when messageData.TryGetProperty("content", out var content) =>
-				new AskAiEvent.Chunk(id, timestamp, content.GetString()!),
+				new AskAiEvent.MessageChunk(id, timestamp, content.GetString()!),
 
 			"ai_message" when messageData.TryGetProperty("content", out var fullContent) =>
-				new AskAiEvent.ChunkComplete(id, timestamp, fullContent.GetString()!),
+				new AskAiEvent.MessageComplete(id, timestamp, fullContent.GetString()!),
 
 			"tool_call" when messageData.TryGetProperty("toolCalls", out var toolCalls) =>
 				TransformToolCall(id, timestamp, toolCalls),

src/api/Elastic.Documentation.Api.Infrastructure/Adapters/AskAi/StreamTransformerBase.cs

@@ -180,7 +180,7 @@ private async Task ProcessStreamAsync(PipeReader reader, PipeWriter writer, Acti
 						outputMessageParts.Add(new MessagePart("reasoning", reasoning.Message ?? string.Empty));
 						break;
 					}
-				case AskAiEvent.Chunk:
+				case AskAiEvent.MessageChunk:
 					{
 						// Event type already tagged above
 						break;
@@ -209,7 +209,7 @@ private async Task ProcessStreamAsync(PipeReader reader, PipeWriter writer, Acti
 						_ = parseActivity?.SetTag("tool.result_summary", toolResult.Result);
 						break;
 					}
-				case AskAiEvent.ChunkComplete chunkComplete:
+				case AskAiEvent.MessageComplete chunkComplete:
 					{
 						outputMessageParts.Add(new MessagePart("text", chunkComplete.FullContent));
 						Logger.LogInformation("AskAI output message: {OutputMessage}", chunkComplete.FullContent);