Skip to content

Commit 162aa07

Browse files
authored
Add explicit continue-on-error input to the preview workflow (#393)
1 parent 3748abb commit 162aa07

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

.github/workflows/preview.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,14 @@ on:
44
workflow_call:
55
inputs:
66
strict:
7+
description: 'Treat warnings as errors'
78
type: boolean
89
default: true
10+
continue-on-error:
11+
description: 'Do not fail to publish if build fails'
12+
type: boolean
13+
required: false
14+
default: true # default for will be false after migration
915

1016
permissions:
1117
id-token: write
@@ -62,7 +68,7 @@ jobs:
6268
- name: Build documentation
6369
if: github.repository != 'elastic/docs-builder'
6470
uses: elastic/docs-builder@main
65-
continue-on-error: ${{ inputs.strict != 'true' }} # Will be removed after the migration phase
71+
continue-on-error: ${{ inputs.continue-on-error == 'true' }} # Will be removed after the migration phase
6672
with:
6773
prefix: "/${{ github.repository }}/pull/${{ github.event.pull_request.number }}"
6874
strict: ${{ inputs.strict }}

actions/publish/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ inputs:
1515
description: 'Treat warnings as errors'
1616
required: false
1717
continue-on-error:
18-
description: 'Treat warnings as errors'
18+
description: 'Do not fail to publish if build fails'
1919
required: false
2020
default: "false"
2121
private:

0 commit comments

Comments
 (0)