Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have you ever heard something about semantic versioning? #2257

Closed
koryukov opened this issue Jan 19, 2024 · 1 comment
Closed

Have you ever heard something about semantic versioning? #2257

koryukov opened this issue Jan 19, 2024 · 1 comment

Comments

@koryukov
Copy link

koryukov commented Jan 19, 2024

The Elastic.Apm.AspNetCore package is distributed using NuGet. So, the Semantic Versioning 2.0.0 is expected. Why has AspNetCoreErrorDiagnosticsSubscriber (a part of public API) been removed in v1.25.1...v1.25.2 release? Why has PATH version been incremented instead of MAJOR?

image

@koryukov koryukov changed the title Have you ever listened something about semantic versioning? Have you ever heard something about semantic versioning? Jan 20, 2024
@Mpdreamz
Copy link
Member

Mpdreamz commented Feb 2, 2024

We have... but we had to make a pragmatic choice.

This class was only used from an internal class (ApmMiddleWare) and we removed the middleware approach to completely centralise the way we instrument ASP.NET core no matter how our users bootstrap the instrumentation.

We felt the removal of a class that arguably should have been internal to begin with outweighed the need to do a full version bump.

#2231

That said we do care deeply about binary compatibility (we even maintain tooling to verify this see: https://github.com/nullean/assembly-differ) and regret this caused an issue for you.

@Mpdreamz Mpdreamz closed this as completed Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants