-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign EITForward(mesh, protocol) API #46
Comments
Great job, that way the api can be really more clear. I think using dataclass can definetly bring improvement and we could do some tests on the data directly which and remove the method like check* in the dataclass directly about the protocol I think only ex_mat and meas_mat (so that multiple type of meas_patttern can be used in future) that way we do not need the meas_pattern method in EITforward () (which shoul only compute fwd results, jac. bp) I will try to implement both dataclass with corresponding wrapper! @dataclass
class PyEITMesh
node
element
perm
el_pos
ref_el
...
@dataclass
class PyEITProtocol
ex_mat
meas_mat
... |
In this way, we may need a wrapper to convert About dataset over dictionary. We generate a mesh object from distmesh or using some exist meshes and write a wrapper to generate the |
see PR #47 |
Done, merge to master. |
Drop |
#88 Inhomogeneous measurement protocol, redefined Previously, This PR implements a vstacked version os The benefit of using this type of measurement matrix is that:
|
The latest dev branch is working on a redesign (not backward compatible) version of
EITForward
class. This new design isolate,mesh
(includingpts
: coordinates of nodes,tri
: the connection of simplices,perm
: permittivity,el_pos
: electrode positions,ref
: reference node),protocol
(ex_mat
: excitation matrix (Neumann BC only, yet),step
: voltage difference electrode,parser
: measurement order).For example,
The mesh and protocol can be a dict, or a dataset(#44), if the code block for building these two data structures (mesh, protocol) are intuitive to use, i.e., see the construction code of mesh and protocol in
examples
.This new version (maybe 2.0) of
pyeit
will be release based on these two milestones:The text was updated successfully, but these errors were encountered: