Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise LLVM tests that are ignored because of missing features #740

Open
jiribenes opened this issue Dec 11, 2024 · 0 comments · May be fixed by #776
Open

Revise LLVM tests that are ignored because of missing features #740

jiribenes opened this issue Dec 11, 2024 · 0 comments · May be fixed by #776
Labels
area:llvm area:tests

Comments

@jiribenes
Copy link
Contributor

We have a lot of tests that are ignored on LLVM because of missing features, but a lot of these are -- I think -- already present in LLVM (like arrays!).

It would be valuable to go over these tests and see:

  • if they still fail but are fixable quickly (perhaps relying on inspect / genericShow for little to no reason)
  • if they actually work but fail with valgrind (then they should be moved to the correct section)
  • if they fail because of missing features (then keep them in the missingFeatures section)
  • if they Just Work ™️ now (then there's no reason to ignore these tests!)

Here are the tests:

effekt/effekt/jvm/src/test/scala/effekt/LLVMTests.scala

Lines 44 to 97 in 92a6e0f

/**
* Documentation of currently failing tests and their reason
*/
lazy val missingFeatures: List[File] = List(
// now show instance for records / datatypes
examplesDir / "pos" / "builtins.effekt",
examplesDir / "pos" / "namespaces.effekt",
examplesDir / "pos" / "triples.effekt",
examplesDir / "pos" / "either.effekt",
// inspect
examplesDir / "pos" / "probabilistic.effekt",
examplesDir / "pos" / "nim.effekt",
examplesDir / "pos" / "exists.effekt",
// arrays
examplesDir / "pos" / "arrays.effekt",
examplesDir / "pos" / "raytracer.effekt",
examplesDir / "pos" / "issue319.effekt",
examplesDir / "pos" / "array",
// Regex
examplesDir / "pos" / "simpleparser.effekt",
// tuples
examplesDir / "pos" / "records.effekt",
// toplevel def and let bindings
examplesDir / "pos" / "capture" / "mbed.effekt",
// unsafe cont
examplesDir / "pos" / "propagators.effekt",
examplesDir / "pos" / "unsafe_cont.effekt",
// Only JS (tests should be moved to a JS folder)
examplesDir / "pos" / "genericcompare.effekt",
examplesDir / "pos" / "multiline_extern_definition.effekt",
examplesDir / "pos" / "maps.effekt",
examplesDir / "pos" / "capture" / "resources.effekt",
examplesDir / "pos" / "io",
// first class functions closing over capabilities
examplesDir / "pos" / "capture" / "state_eff.effekt",
// higher order foreign functions are not supported
examplesDir / "pos" / "capture" / "ffi_blocks.effekt",
// See PR #355
examplesDir / "llvm" / "string_toint.effekt",
// Generic equality
examplesDir / "pos" / "issue429.effekt",
)

@marvinborner marvinborner linked a pull request Jan 14, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:llvm area:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revise ignored LLVM tests effekt-lang/effekt
1 participant
@jiribenes