Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup update #348

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Setup update #348

wants to merge 21 commits into from

Conversation

marwaneltoukhy
Copy link
Member

@marwaneltoukhy marwaneltoukhy commented Nov 29, 2023

This PR is intended to solve user issues where the environment isn't up to date with the latest releases from efabless.

  1. change make setup to use a python script, making it easier to download and prettier
  2. make setup now uses central CI repo to fetch the versions from upstream
  3. make setup outputs tool_versions.json to indicate which tools the user is using in their environment
  4. make setup now has a log file called setup.log
  5. all targets run check_environment which checks their tools versions and compares it to the upstream json file, if any version is outdated it will throw an error and exit
  6. Added 2 targets to open last failed run's layout open-gui-<module-name> and open-odb-gui-<module_name>

@marwaneltoukhy marwaneltoukhy marked this pull request as ready for review December 4, 2023 11:14
@kareefardi
Copy link
Contributor

kareefardi commented Dec 4, 2023

@marwaneltoukhy the docs has some instructions using make install, make install_mcw and other make targets that are removed by this PR. The docs should be updated accordingly.
Edit:
My bad. I can see that the targets haven't been removed.

@marwaneltoukhy
Copy link
Member Author

@marwaneltoukhy the docs reference make install, make install_mcw and other make targets that are removed by this PR. The docs should be updated accordingly.

They are included

@marwaneltoukhy marwaneltoukhy requested a review from donn December 6, 2023 10:42
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@jeffdi jeffdi requested a review from mattvenn December 20, 2023 16:19
@mattvenn
Copy link
Contributor

run make setup (with no PDK/OPENLANE ROOT set)

got a warning: Makefile:48: warning: undefined variable 'MPW_TAG'
also it says it's installing cocotb, which might not be what's wanted as it could overwrite a version I already have. I thought cocotb was usually used inside the dockers?

afterwards get the expected files in dependencies.

I get tool_versions.json created (attached)
tool_versions.json

setup.log looks fine, (feature request - add timestamps)

next I run make user_proj_example (I need to remember to use a different demo project, this takes tooooo long)

wasn't sure how to test the check_environment functionality.

make open-gui-user_proj_example

seems to hang:
image

open-odb-gui-user_proj_example

fails with a stacktrace

image

I then removed dependencies, set PDK and OPENLANE ROOT and installed again. I was able to build the user project again.

@marwaneltoukhy
Copy link
Member Author

@mattvenn I can't replicate the issue you're seeing with opening the gui, this is an OS specific issue. Can you try adding --privileged in the docker_extra_args in openlane/Makefile, and let me know if that works for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants