Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple buy before any sell #3

Open
lamhk opened this issue May 18, 2018 · 2 comments
Open

Multiple buy before any sell #3

lamhk opened this issue May 18, 2018 · 2 comments

Comments

@lamhk
Copy link

lamhk commented May 18, 2018

Hi, I found that there maybe multiple buying if the action == 1 is true, which means the program will record multiple buy before any sell could happen. And there is no limit of number of "buy" could be allowed. This is very different from real life situation. Am my understanding correct? However, when I tried to limit the "buy" to 1 if the system already hold a long position. I found the result during training is not stable and most of the time is negative. Do I miss something? Many thanks in advance.

@windwine
Copy link

windwine commented Feb 5, 2019

I noticed the same thing. By doing so when you include a training sample with upward bias the agent will just try to pile on every single dip. It is just a martingale betting system.

@zjs81
Copy link

zjs81 commented Aug 15, 2021

I implemented a money system and it doesn't seem worth it. I used the "Better method from the pull requests" Going to do this with the standard and see if I get better results.
https://github.com/zjs81/q-trader

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants