Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve environment banner to show we're pointed at localhost -db #211

Open
lightandluck opened this issue Mar 4, 2018 · 7 comments
Open

Comments

@lightandluck
Copy link
Collaborator

There is a useful banner that shows if we are pointed at staging-db or not, but doesn't show for other instances.

Expected Behavior

It would be useful while developing if this banner also showed if we are pointed at localhost or production-db.

Current Behavior

It only shows if we are pointed at staging-db

Context

I accidentally made an annotation to the production-db while testing #210. I probably wouldn't have made that mistake if it showed which -db I was pointing at.

@lightandluck
Copy link
Collaborator Author

Notes from 3/7/18 dev call:

  1. This banner should definitely not show in production. Haven't had a chance to look at it's implementation, but sounds like it could happen.
  2. Move the banner to top of the screen, instead of the middle of page.

@Mr0grog
Copy link
Member

Mr0grog commented Mar 16, 2018

@lightandluck are you working on this?

@lightandluck
Copy link
Collaborator Author

Sorry, no. Haven't had a chance to look at this yet.

@stale
Copy link

stale bot commented Jan 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs. If it should not be closed, please comment! Thank you for your contributions.

@stale stale bot added the stale label Jan 10, 2019
@Mr0grog
Copy link
Member

Mr0grog commented Jan 10, 2019

Augh. This is still a thing that feels important.

@stale stale bot removed the stale label Jan 10, 2019
@stale
Copy link

stale bot commented Jul 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs. If it should not be closed, please comment! Thank you for your contributions.

@stale stale bot added the stale label Jul 9, 2019
@stale stale bot removed the stale label Jul 9, 2019
@lightandluck
Copy link
Collaborator Author

lightandluck commented Jul 9, 2019

Added never-stale label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants