Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always send all form fields in annotation #133

Open
Mr0grog opened this issue Oct 1, 2017 · 3 comments
Open

Always send all form fields in annotation #133

Mr0grog opened this issue Oct 1, 2017 · 3 comments

Comments

@Mr0grog
Copy link
Member

Mr0grog commented Oct 1, 2017

The API rightly rejects an empty, meaningless annotation, but we are still trying to send an empty annotation if you never check/uncheck any of the fields before clicking “update record.”

Instead, we should actually be sending the value for every field, regardless of what’s been clicked. These values are all either “yes” or “no;” there’s no “unknown” or non-value value that should be implied by not having checked one.

@Mr0grog Mr0grog added this to the V0 milestone Oct 1, 2017
@danielballan danielballan removed this from the V0 milestone Oct 9, 2017
@stale
Copy link

stale bot commented Jan 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs. If it should not be closed, please comment! Thank you for your contributions.

@stale stale bot added the stale label Jan 10, 2019
@Mr0grog
Copy link
Member Author

Mr0grog commented Jan 10, 2019

This is an important fix.

@stale stale bot removed the stale label Jan 10, 2019
@stale
Copy link

stale bot commented Jul 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs. If it should not be closed, please comment! Thank you for your contributions.

@stale stale bot added the stale label Jul 9, 2019
@Mr0grog Mr0grog added the bug label Jul 15, 2019
@stale stale bot removed the stale label Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants