Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make edge-impulse-config.json a hidden .edge-impulse-config.json file #17

Open
kashif opened this issue Jul 12, 2021 · 5 comments
Open

Comments

@kashif
Copy link

kashif commented Jul 12, 2021

might be nicer aesthetically if edge-impulse-config.json is a ~/.edge-impulse-config.json file

@codeanpeace
Copy link

codeanpeace commented Feb 19, 2022

seconded! came here to say this too

    constructor() {
        this._filename = Path.join(os.homedir(), 'edge-impulse-config.json');
    }

Only reference to it I could find – seems like the tricky bit would be backward compatibility..

@kashif
Copy link
Author

kashif commented Feb 19, 2022

not really tricky... in the code, if it finds the config in home it should just move it to a hidden folder/file... else just read from the hidden folder/file...

@codeanpeace
Copy link

Ahh yeah, fair enough – definitely an edge case so probably no need to support aside from a printed warning, but a straightforward move would mess with anyone who also uses symlinks for their dotfiles ala mackup

@codeanpeace
Copy link

codeanpeace commented Mar 25, 2022

Took a crack at a targeted approach that should hopefully allow people to convert the edge impulse config file into a dotfile without affecting others in this small PR

Tagging @janjongboom and @ijdoc for their input as they're familiar with the entirety of the CLI

@ijdoc
Copy link
Contributor

ijdoc commented Mar 25, 2022

thanks @codeanpeace , I will review and see about pushing this upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants