Fixed podspec to work correctly on React-Native 0.60x#40
Open
albertgimenez wants to merge 1 commit intoeddieowens:masterfrom
Open
Fixed podspec to work correctly on React-Native 0.60x#40albertgimenez wants to merge 1 commit intoeddieowens:masterfrom
albertgimenez wants to merge 1 commit intoeddieowens:masterfrom
Conversation
This fix refactors the previous pod spec to use the info from the package.json instead of be hardcoded. Also fixes pod install so correctly can be auto linked on React-Native 0.60x.
r0b0t3d
reviewed
Aug 12, 2020
| s.license = package['license'] | ||
|
|
||
| s.authors = package['author'] | ||
| s.homepage = package['homepage'] |
There was a problem hiding this comment.
Got this error
[!] The `RNBoundary` pod failed to validate due to 1 error:
- ERROR | attributes: Missing required attribute `homepage`.
there is no homepage prop in package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix refactors the previous pod spec to use the info from the package.json instead of be hardcoded.
Also fixes pod install so correctly can be auto linked on React-Native 0.60x.