-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
can't login anymore - "ValueError: unknown url type: 'None'" #75
Comments
Thanks for raising this. I'll try to take a look soon |
Hello, I'm not sure if any of that is helpful in any way but I though I'll share my finding from a little bit of digging. |
FYI, Kalanyr's version seems to be working fine. I haven't compared the login code to see if it's something obvious/trivial. |
Yeah, this must be a change on GOG's back end that occurred well beyond my rewrite to support Python 3. I apologize if that came off as confusing, and I also appreciate the time taken to see if my fork worked. 🙏 |
Kalanyr's version indeed seems to work. |
The login code in Kalanyr's version seems more complex, and also calls out to other functions that they'd written. More than that, there appears to have been a significant amount of refactoring and expansion (3991 LOC versus 1175 LOC), so backporting |
Yeah sorry folks this will take time. I'd suggest you use one of the various forks for now. Sorry for the inconvenience. |
No, not at all! I can't speak for everyone, but I deeply appreciate the work you did to create this utility in the first place. Take the time you need! |
I second what ToxiClay said. No worries and thank you for you work, @eddie3 ! |
Anyone else seeing this preventing logging in or using the script?
This is using Python 3.11.2. I also tried ToxiClay's version, which specifically claims as tested on Python 3.11.2 and I get the same output.
Any help much appreciated!
Thanks
The text was updated successfully, but these errors were encountered: