Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't login anymore - "ValueError: unknown url type: 'None'" #75

Open
nazgul6 opened this issue Aug 12, 2024 · 9 comments
Open

can't login anymore - "ValueError: unknown url type: 'None'" #75

nazgul6 opened this issue Aug 12, 2024 · 9 comments

Comments

@nazgul6
Copy link

nazgul6 commented Aug 12, 2024

Anyone else seeing this preventing logging in or using the script?

Traceback (most recent call last):
File "/root/gog-script/gogrepo.py", line 1210, in
main(process_argv(sys.argv))
File "/root/gog-script/gogrepo.py", line 1182, in main
cmd_login(args.username, args.password)
File "/root/gog-script/gogrepo.py", line 560, in cmd_login
with request(login_data['auth_url'], delay=0) as page:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/root/gog-script/gogrepo.py", line 167, in request
req = Request(url, data=enc_args)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/urllib/request.py", line 322, in init
self.full_url = url
^^^^^^^^^^^^^
File "/usr/lib/python3.11/urllib/request.py", line 348, in full_url
self._parse()
File "/usr/lib/python3.11/urllib/request.py", line 377, in _parse
raise ValueError("unknown url type: %r" % self.full_url)
ValueError: unknown url type: 'None'

This is using Python 3.11.2. I also tried ToxiClay's version, which specifically claims as tested on Python 3.11.2 and I get the same output.

Any help much appreciated!

Thanks

@eddie3
Copy link
Owner

eddie3 commented Aug 12, 2024

Thanks for raising this. I'll try to take a look soon

@Donione
Copy link

Donione commented Aug 15, 2024

Hello,
I've just encountered this as well.
It seems that fetching the auth url fails to find any.
When I replaced login_data['auth_url'] with 'login.gog.com/login' in the fetch the login token step I was prompted to enter the two-step security code. I've received it and entered it but the login still failed.
Since then when I try logging in, I'm not prompted to enter the security code anymore and the login fails.

I'm not sure if any of that is helpful in any way but I though I'll share my finding from a little bit of digging.

@Donione
Copy link

Donione commented Aug 25, 2024

FYI, Kalanyr's version seems to be working fine. I haven't compared the login code to see if it's something obvious/trivial.

@ToxiClay
Copy link

ToxiClay commented Aug 26, 2024

This is using Python 3.11.2. I also tried ToxiClay's version, which specifically claims as tested on Python 3.11.2 and I get the same output.

Yeah, this must be a change on GOG's back end that occurred well beyond my rewrite to support Python 3. I apologize if that came off as confusing, and I also appreciate the time taken to see if my fork worked. 🙏

@nazgul6
Copy link
Author

nazgul6 commented Aug 26, 2024

Kalanyr's version indeed seems to work.

@ToxiClay
Copy link

ToxiClay commented Sep 1, 2024

FYI, Kalanyr's version seems to be working fine. I haven't compared the login code to see if it's something obvious/trivial.

The login code in Kalanyr's version seems more complex, and also calls out to other functions that they'd written. More than that, there appears to have been a significant amount of refactoring and expansion (3991 LOC versus 1175 LOC), so backporting cmd_login feels like it'd be a challenge.

@eddie3
Copy link
Owner

eddie3 commented Sep 2, 2024

Yeah sorry folks this will take time. I'd suggest you use one of the various forks for now. Sorry for the inconvenience.

@ToxiClay
Copy link

ToxiClay commented Sep 2, 2024

No, not at all! I can't speak for everyone, but I deeply appreciate the work you did to create this utility in the first place. Take the time you need!

@Donione
Copy link

Donione commented Sep 2, 2024

I second what ToxiClay said. No worries and thank you for you work, @eddie3 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants