fixup! Create module sale_invoice_line_note

Author: grindtildeath

sale_invoice_line_note/tests/test_sale_invoice_line_note.py

@@ -43,3 +43,16 @@ def test_sale_note_to_invoice(self):
         )
         self.assertEqual(invoice_line_note.name, 'Test sale order line note')
         self.assertEqual(invoice_line_note.sequence, 12)
+
+    def test_sale_note_no_copy(self):
+        wizard = self.env['sale.advance.payment.inv'].with_context(
+            active_ids=self.sale_order.ids).create({
+            'advance_payment_method': 'all',
+        })
+        wizard.copy_notes_to_invoice = False
+        wizard.create_invoices()
+        invoice = self.sale_order.invoice_ids
+        invoice_line_note = invoice.invoice_line_ids.filtered(
+            lambda l: l.display_type == 'line_note'
+        )
+        self.assertFalse(invoice_line_note)

sale_invoice_line_note/wizard/sale_make_invoice_advance.py

@@ -17,6 +17,5 @@ class SaleAdvancePaymentInv(models.TransientModel):
     @api.multi
     def create_invoices(self):
         if self.copy_notes_to_invoice:
-            return super(SaleAdvancePaymentInv, self.with_context(
-                _copy_notes=True)).create_invoices()
+            self = self.with_context(_copy_notes=True)
         return super().create_invoices()