Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default ESM package #762

Closed
1 task done
Shyam-Chen opened this issue Feb 20, 2024 · 2 comments
Closed
1 task done

Default ESM package #762

Shyam-Chen opened this issue Feb 20, 2024 · 2 comments

Comments

@Shyam-Chen
Copy link

Shyam-Chen commented Feb 20, 2024

Confirmation

  • I can confirm this is a feature request for the Vue component instead of ECharts itself.

Details

Ref: apache/echarts#19513 (echarts v5.5)

Would you like to follow the updates?

@Shyam-Chen
Copy link
Author

Shyam-Chen commented Feb 20, 2024

If supported, Vitest could do without this line.

# vitest
  resolve: {
-   mainFields: ['module'],
  },
Instead change the require of core.js in /Users/path/to/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/vue-echarts/dist/index.cjs.min.js to a dynamic import() which is available in all CommonJS modules.
 ❯ Object.<anonymous> node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/vue-echarts/dist/index.cjs.min.js:1:97

@Shyam-Chen Shyam-Chen reopened this Feb 20, 2024
@Justineo
Copy link
Member

Let's track this at #627.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants