Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disentangle graph and model config. #30

Open
dietervdb-meteo opened this issue Dec 3, 2024 · 0 comments
Open

Disentangle graph and model config. #30

dietervdb-meteo opened this issue Dec 3, 2024 · 0 comments
Labels
enhancement New feature or request models

Comments

@dietervdb-meteo
Copy link
Contributor

dietervdb-meteo commented Dec 3, 2024

Is your feature request related to a problem? Please describe.

This is a minor issue, but might still be worth considering.

When an instance of AnemoiModelEncProcDec gets initiated the names of the data and hidden nodes of the graph are looked up in the graph config:

self._graph_name_data = model_config.graph.data
self._graph_name_hidden = model_config.graph.hidden

This is counter intuitive, especially when one would like to train the model with a pre-created graph stored on disk. In that case one would expect the graph part of the config to simply read:

overwrite: False

Although this will lead to the graph being loaded it will also produce an error, since as described above creation of the model needs the following lines to always be present in the graph config

data: name_of_data_nodes #typically 'data'
hidden: name_of_hidden_nodes #typically 'hidden'

Describe the solution you'd like

It would be cleaner if either
a) The names of hidden and data nodes are stored in the graph itself
b) These names are specified in the model config

Describe alternatives you've considered

No response

Additional context

No response

Organisation

RMI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request models
Projects
None yet
Development

No branches or pull requests

2 participants