Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of NoStackTraceThrowable #4082

Open
kolstae opened this issue Aug 26, 2021 · 1 comment
Open

Use of NoStackTraceThrowable #4082

kolstae opened this issue Aug 26, 2021 · 1 comment
Labels

Comments

@kolstae
Copy link

kolstae commented Aug 26, 2021

When using kotlin coroutines the use of NoStackTraceThrowable causes problems that are really hard to find.

This code will not catch the error

    try {
        pool.preparedQuery("select true = $1").execute(Tuple.of(12)).await()
    } catch (e: Exception) {
        LOG.error("Expected: {}", e.toString())
    }

to catch the error we would need to catch Throwable which forces us to check if it's an Error.
When using futures directly, this isn't as much of a problem I guess.

@kolstae kolstae added the bug label Aug 26, 2021
@magicprinc
Copy link
Contributor

Vote for issue #4854

PS: #4855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants