Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve package size #455

Open
3 tasks
jfaltermeier opened this issue Feb 6, 2025 · 10 comments
Open
3 tasks

Improve package size #455

jfaltermeier opened this issue Feb 6, 2025 · 10 comments

Comments

@jfaltermeier
Copy link
Contributor

jfaltermeier commented Feb 6, 2025

Feature Description:

We should investigate whether we can reduce the installer size.

At first glance, the package already looks pretty minimal, but it still includes source maps. A big portion of the size comes from VSIX extensions, which we can't control.

Overview:
Image

Source Maps:
Image

It might also be worth checking whether we can enable ASAR (see

). However, we previously had issues with VSIX extensions and executables inside them, so this needs careful testing.

  • Remove source maps
  • Investigate whether we can enable Asar
  • Look for other potential improvements.
@jfaltermeier
Copy link
Contributor Author

@JonasHelming FYI

@JonasHelming
Copy link
Contributor

@jfaltermeier Are the vsix extensions only built-ins or what do we install by default?

@jfaltermeier
Copy link
Contributor Author

@jfaltermeier Are the vsix extensions only built-ins or what do we install by default?

It's the built-ins and two for Java support: https://github.com/eclipse-theia/theia-ide/blob/master/package.json#L64-L66

@tsmaeder
Copy link
Contributor

Please don't remove source maps without providing an alternative (source maps can point to an internet URI). Otherwise production builds become undebuggable.

@JonasHelming
Copy link
Contributor

@tsmaeder Are the built-ins the exact same as for VS Code?
Also: should we maybe remove Java as a built-in?

@JonasHelming
Copy link
Contributor

@tsmaeder see question above, please

@tsmaeder
Copy link
Contributor

Looks like we're including pretty much the same extensions as they do (they have ~90), but we remove some stuff like github, etc. The only additional stuff I see is the java plugins. In any case, there is no difference that would be really relevant to the size of the package outside of the Java stuff.

@JonasHelming
Copy link
Contributor

@tsmaeder @jfaltermeier Do you remember, why we include Java? I would actually be in favor of removing it.

@jfaltermeier
Copy link
Contributor Author

We have a small Java example in the Try Now Online Demo and I think we included it because Eclipse Desktop IDE users often are Java users.

@tsmaeder
Copy link
Contributor

I was not involved in that decision, so I don't know the rationale for including it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants