Skip to content

BuildTests.testPluginFiles fails for org.eclipse.swt.svg.source #2009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iloveeclipse opened this issue Apr 14, 2025 · 2 comments · Fixed by #2010
Closed

BuildTests.testPluginFiles fails for org.eclipse.swt.svg.source #2009

iloveeclipse opened this issue Apr 14, 2025 · 2 comments · Fixed by #2010
Labels
bug Something isn't working regression Something that used to work
Milestone

Comments

@iloveeclipse
Copy link
Member

Regression from #1638.

See https://download.eclipse.org/eclipse/downloads/drops4/I20250413-1800/testresults/html/org.eclipse.releng.tests_ep436I-unit-linux-x86_64-java21_linux.gtk.x86_64_21.html

Plugin directory missing required files: /home/jenkins/agent/workspace/AutomatedTests/ep436I-unit-linux-x86_64-java21/workarea/I20250413-1800/eclipse-testing/test-eclipse/eclipse/plugins/org.eclipse.swt.svg.source_3.130.0.v20250327-2110.jar;

java.lang.AssertionError: Plugin directory missing required files: /home/jenkins/agent/workspace/AutomatedTests/ep436I-unit-linux-x86_64-java21/workarea/I20250413-1800/eclipse-testing/test-eclipse/eclipse/plugins/org.eclipse.swt.svg.source_3.130.0.v20250327-2110.jar;
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.assertTrue(Assert.java:42)
at org.eclipse.releng.tests.BuildTests.testPluginFiles(BuildTests.java:182)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)

I assume about.html is missing in org.eclipse.swt.svg.source.

@iloveeclipse iloveeclipse added bug Something isn't working regression Something that used to work labels Apr 14, 2025
@iloveeclipse iloveeclipse added this to the 4.36 M2 milestone Apr 14, 2025
@HeikoKlare
Copy link
Contributor

Thank you for the analysis, @iloveeclipse!

The erroneous bundle was introduced with #1638. The test failure shows up now because the bundle was added to the SDK via eclipse-platform/eclipse.platform#1797

The merged commit fits into the time frame when the test failure showed up:
First build showing the failure is: I20250411-1800
Last build without the failure is: I20250411-0200

I agree that the missing about.html seems to cause the issue. If I am not mistaken it should not only be added to the source bundle but also to the binary bundle. I'll provide an according PR.

HeikoKlare added a commit to HeikoKlare/eclipse.platform.swt that referenced this issue Apr 14, 2025
…rm#2009

The recently added org.eclipse.swt.svg fragment is lacking the required
about.html file. This change adds the file to the generated source and
binary artifacts bundles.

Fixes eclipse-platform#2009
HeikoKlare added a commit to HeikoKlare/eclipse.platform.swt that referenced this issue Apr 14, 2025
…rm#2009

The recently added org.eclipse.swt.svg fragment is lacking the required
about.html file. This change adds the file to the generated source and
binary artifacts bundles.

Fixes eclipse-platform#2009
HeikoKlare added a commit to HeikoKlare/eclipse.platform.swt that referenced this issue Apr 15, 2025
…rm#2009

The recently added org.eclipse.swt.svg fragment is lacking the required
about.html file. This change adds the file to the generated source and
binary artifacts bundles.

Fixes eclipse-platform#2009
@HeikoKlare
Copy link
Contributor

Today's build results show that this has been properly resolved by:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Something that used to work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants