Skip to content

Commit 50f3cc5

Browse files
committed
Adapt tests to the new NameEnricher behaviour
Signed-off-by: Amirouche <[email protected]>
1 parent b082aab commit 50f3cc5

File tree

1 file changed

+16
-2
lines changed

1 file changed

+16
-2
lines changed

jkube-kit/enricher/generic/src/test/java/org/eclipse/jkube/enricher/generic/NameEnricherTest.java

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ void create_withAlreadyExistingName_shouldKeepExistingName() {
118118
}
119119

120120
@Test
121-
void create_withCustomNameAndAlreadyExistingName_shouldOverrideExistingName() {
121+
void create_withCustomNameAndAlreadyExistingName_shouldKeepExistingName() {
122122
// Given
123123
klb = new KubernetesListBuilder();
124124
properties.put("jkube.enricher.jkube-name.name", "custom-name");
@@ -128,6 +128,20 @@ void create_withCustomNameAndAlreadyExistingName_shouldOverrideExistingName() {
128128
// Then
129129
assertThat(klb.build().getItems())
130130
.singleElement()
131-
.hasFieldOrPropertyWithValue("metadata.name", "custom-name");
131+
.hasFieldOrPropertyWithValue("metadata.name", "existing-name");
132+
}
133+
134+
@Test
135+
void create_withoutName_shouldSetGivenCustomName() {
136+
// Given
137+
klb = new KubernetesListBuilder();
138+
properties.put("jkube.enricher.jkube-name.name", "custom-name");
139+
// When
140+
klb.addToItems(new ServiceBuilder().withNewMetadata().endMetadata().build());
141+
new NameEnricher(context).create(PlatformMode.kubernetes, klb);
142+
// Then
143+
assertThat(klb.build().getItems())
144+
.singleElement()
145+
.hasFieldOrPropertyWithValue("metadata.name", "custom-name");
132146
}
133147
}

0 commit comments

Comments
 (0)