Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Enhancement request for ApacheConnector (jersey-apache-connector) #3778

Open
jerseyrobot opened this issue Feb 24, 2018 · 1 comment

Comments

@jerseyrobot
Copy link
Contributor

Hi,

We are user of the jersey-apache-connector project. The endpoint of the project is the ApacheConnector class which does not allow extending/modification. But in our case we need to be able to modify the Apache ClientBuilder with our own SSL settings (cloud settings) and also we need to do more logic rather than simply call ClientBuilder.build().

The ideal working sample for us is to modify the signature of ApacheConnector to be:

public ApacheConnector(final Client client, final Configuration config, final ClientBuilderModifier builderModifier) {

...................
...................
...................
//Then at the very end, add the following logic.

    //Support external modifier
    if (null != builderModifier) {
        builderModifier.custom(clientBuilder);
        this.client = builderModifier.build();
    } else {
        this.client = clientBuilder.build();
    }

}

That way we adds flexibility to the ApacheConnector project.

I have implemented the logic and created a pull request
https://github.com/jersey/jersey/pull/3777

Please kindly review and let me know if I need to anything.
Thanks,
Benjamin

@jerseyrobot
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant