Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: default extension in visual studio code #2819

Merged
merged 17 commits into from
Nov 19, 2024
Merged

docs: default extension in visual studio code #2819

merged 17 commits into from
Nov 19, 2024

Conversation

vitaliy-guliy
Copy link
Contributor

@vitaliy-guliy vitaliy-guliy commented Nov 13, 2024 •
edited
Loading

What does this pull request change?

Adds a page telling how to add default extension to Visual Studio Code.

Screenshot from 2024-11-19 11-54-50

Screenshot from 2024-11-19 11-55-00

Screenshot from 2024-11-19 11-55-09

Screenshot from 2024-11-19 11-55-18

Screenshot from 2024-11-19 11-55-23

What issues does this pull request fix or reference?

Downstream issue https://issues.redhat.com/browse/CRW-7246
And there is corresponding PR to che-code che-incubator/che-code#424

Specify the version of the product this pull request applies to

main

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@vitaliy-guliy vitaliy-guliy requested review from deerskindoll and a team as code owners November 13, 2024 16:24
@vitaliy-guliy vitaliy-guliy requested a review from l0rd November 13, 2024 16:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

Click here to review and test in web IDE: Contribute

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

🎊 Navigate the preview: 🎊

@vitaliy-guliy vitaliy-guliy marked this pull request as draft November 14, 2024 13:24
vitaliy-guliy and others added 3 commits November 14, 2024 15:25
@vitaliy-guliy @dkwon17
Update modules/administration-guide/pages/default-extensions-for-micr…
9813b95 
…osoft-visual-studio-code.adoc

Co-authored-by: David Kwon <[email protected]>
@vitaliy-guliy @dkwon17
Update modules/administration-guide/pages/default-extensions-for-micr…
8733569 
…osoft-visual-studio-code.adoc

Co-authored-by: David Kwon <[email protected]>
@vitaliy-guliy @dkwon17
Update modules/administration-guide/pages/default-extensions-for-micr…
70d1e5a 
…osoft-visual-studio-code.adoc

Co-authored-by: David Kwon <[email protected]>
vitaliy-guliy and others added 5 commits November 14, 2024 15:27
@vitaliy-guliy vitaliy-guliy marked this pull request as ready for review November 14, 2024 19:23
@vitaliy-guliy @dkwon17
Update modules/administration-guide/pages/default-extensions-for-micr…
b18352c 
…osoft-visual-studio-code.adoc

Co-authored-by: David Kwon <[email protected]>
deerskindoll
deerskindoll reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited the doc for better readability and to conform to the RH Style guidelines.

modules/administration-guide/pages/default-extensions-for-microsoft-visual-studio-code.adoc Outdated Show resolved Hide resolved
modules/administration-guide/pages/default-extensions-for-microsoft-visual-studio-code.adoc Outdated Show resolved Hide resolved
modules/administration-guide/pages/default-extensions-for-microsoft-visual-studio-code.adoc Outdated Show resolved Hide resolved
modules/administration-guide/pages/default-extensions-for-microsoft-visual-studio-code.adoc Outdated Show resolved Hide resolved
modules/administration-guide/pages/default-extensions-for-microsoft-visual-studio-code.adoc Outdated Show resolved Hide resolved
modules/administration-guide/pages/default-extensions-for-microsoft-visual-studio-code.adoc Outdated Show resolved Hide resolved
modules/administration-guide/pages/default-extensions-for-microsoft-visual-studio-code.adoc Outdated Show resolved Hide resolved
modules/administration-guide/pages/default-extensions-for-microsoft-visual-studio-code.adoc Outdated Show resolved Hide resolved
modules/administration-guide/pages/default-extensions-for-microsoft-visual-studio-code.adoc Outdated Show resolved Hide resolved
modules/administration-guide/pages/default-extensions-for-microsoft-visual-studio-code.adoc Outdated Show resolved Hide resolved
@vitaliy-guliy vitaliy-guliy marked this pull request as draft November 17, 2024 12:35
vitaliy-guliy and others added 2 commits November 17, 2024 15:12
@vitaliy-guliy @deerskindoll
Apply suggestions from code review
5d0d01b 
Co-authored-by: Jana Vrbkova <[email protected]>
@vitaliy-guliy
Apply formatting
723ef3e 
Signed-off-by: Vitaliy Gulyy <[email protected]>
deerskindoll
deerskindoll reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of mostly formatting edits

modules/administration-guide/pages/default-extensions-for-microsoft-visual-studio-code.adoc Outdated Show resolved Hide resolved
modules/administration-guide/pages/default-extensions-for-microsoft-visual-studio-code.adoc Outdated Show resolved Hide resolved
modules/administration-guide/pages/default-extensions-for-microsoft-visual-studio-code.adoc Outdated Show resolved Hide resolved
modules/administration-guide/pages/default-extensions-for-microsoft-visual-studio-code.adoc Outdated Show resolved Hide resolved
modules/administration-guide/pages/default-extensions-for-microsoft-visual-studio-code.adoc Outdated Show resolved Hide resolved
modules/administration-guide/pages/default-extensions-for-microsoft-visual-studio-code.adoc Outdated Show resolved Hide resolved
modules/administration-guide/pages/default-extensions-for-microsoft-visual-studio-code.adoc Outdated Show resolved Hide resolved
modules/administration-guide/pages/default-extensions-for-microsoft-visual-studio-code.adoc Outdated Show resolved Hide resolved
modules/administration-guide/pages/default-extensions-for-microsoft-visual-studio-code.adoc Outdated Show resolved Hide resolved
modules/administration-guide/pages/default-extensions-for-microsoft-visual-studio-code.adoc Outdated Show resolved Hide resolved
deerskindoll
deerskindoll approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vitaliy-guliy vitaliy-guliy marked this pull request as ready for review November 19, 2024 14:42
@vitaliy-guliy vitaliy-guliy merged commit 7c82517 into main Nov 19, 2024
10 checks passed
@vitaliy-guliy vitaliy-guliy deleted the vscode-default-extensions branch November 19, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkwon17 dkwon17 dkwon17 approved these changes

@deerskindoll deerskindoll deerskindoll approved these changes

@l0rd l0rd Awaiting requested review from l0rd l0rd is a code owner automatically assigned from eclipse-che/ecd-che-docs-reviewers

@ibuziuk ibuziuk Awaiting requested review from ibuziuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitaliy-guliy @deerskindoll @dkwon17