Cleanup the terminal/ folder in CDT's source (#1360)

Now that the terminal has migrated to the Eclipse Platform this commit
moves around the remaining parts of the terminal to their
correct location in the CDT source tree

- Move terminal connector features next to their defining bundles
- Remove terminal-only profile from CDT's build system.
- Remove terminal/ references in build scripts
- Rename remaining connectors (cdtserial/remote) so their
  display name reflects new naming scheme.
- Renaming bundles and packages for remaining connectors is
  excluded, a readme has been added to each explaining name

Author: jonahgraham

.github/workflows/build-test.yml

@@ -77,7 +77,6 @@ jobs:
         path: |
           event.json
           */*/target/surefire-reports/*.xml
-          terminal/plugins/org.eclipse.tm.terminal.test/target/surefire-reports/*.xml
     - name: Prepare Docs for upload
       if: (success() || failure()) && steps.filter.outputs.docs
       run: |

BUILDING.md

@@ -74,13 +74,6 @@ Individual p2 repos can be turned on and off to allow building CDT, or parts of
 
 Using any of the above profiles can skip large sets of tests. The CI build uses this to parallelize tests. See https://ci.eclipse.org/cdt/view/Gerrit/
 
-#### terminal-only
-
-The terminal directory has a special profile that enables only the terminal and its dependencies when used. The allows
-running maven like this `mvn -f terminal/pom.xml verify -P only-terminal` to build and test only the terminal
-and its dependencies. A special terminal only p2 site is created in `terminal/repo/target/repository`. The CI build
-uses this to speedup turnaround on changes only affecting the terminal. See https://ci.eclipse.org/cdt/view/Gerrit/
-
 #### baseline-compare-and-replace
 
 `baseline-compare-and-replace` profile controls whether baseline replace and compare

Jenkinsfile

@@ -104,8 +104,8 @@ pipeline {
   post {
     always {
       container('cdt') {
-        archiveArtifacts '*.log,serial/org.eclipse.cdt.native.serial/**,core/org.eclipse.cdt.core.*/**,*/*/target/surefire-reports/**,terminal/plugins/org.eclipse.tm.terminal.test/target/surefire-reports/**,**/target/work/data/.metadata/.log,releng/org.eclipse.cdt.repo/target/org.eclipse.cdt.repo.zip,releng/org.eclipse.cdt.repo/target/repository/**,releng/org.eclipse.cdt.testing.repo/target/org.eclipse.cdt.testing.repo.zip,releng/org.eclipse.cdt.testing.repo/target/repository/**,debug/org.eclipse.cdt.debug.application.product/target/product/*.tar.gz,debug/org.eclipse.cdt.debug.application.product/target/products/*.zip,debug/org.eclipse.cdt.debug.application.product/target/products/*.tar.gz,debug/org.eclipse.cdt.debug.application.product/target/repository/**'
-        junit '*/*/target/surefire-reports/*.xml,terminal/plugins/org.eclipse.tm.terminal.test/target/surefire-reports/*.xml'
+        archiveArtifacts '*.log,serial/org.eclipse.cdt.native.serial/**,core/org.eclipse.cdt.core.*/**,*/*/target/surefire-reports/**,**/target/work/data/.metadata/.log,releng/org.eclipse.cdt.repo/target/org.eclipse.cdt.repo.zip,releng/org.eclipse.cdt.repo/target/repository/**,releng/org.eclipse.cdt.testing.repo/target/org.eclipse.cdt.testing.repo.zip,releng/org.eclipse.cdt.testing.repo/target/repository/**,debug/org.eclipse.cdt.debug.application.product/target/product/*.tar.gz,debug/org.eclipse.cdt.debug.application.product/target/products/*.zip,debug/org.eclipse.cdt.debug.application.product/target/products/*.tar.gz,debug/org.eclipse.cdt.debug.application.product/target/repository/**'
+        junit '*/*/target/surefire-reports/*.xml'
       }
     }
   }

RELEASING.md

@@ -80,7 +80,7 @@ find $CDT_ROOT -type f -name MANIFEST.MF -exec sed -i s/12.2.0.qualifier/12.3.0.
 - Update Marketplace entries:
     - https://marketplace.eclipse.org/content/complete-eclipse-cc-ide/edit (Complete C/C++ IDE)
     - https://marketplace.eclipse.org/content/eclipse-cc-ide/edit (CDT)
-    - https://marketplace.eclipse.org/content/tm-terminal/edit (Terminal)
+    - https://marketplace.eclipse.org/content/eclipse-terminal/edit (Terminal) -- TODO hand ownership to Eclipse Platform
 - Publish the GitHub release page and create a discussion for it.
 - Forward the discussion email to cdt-dev
 - Update cdt.aggrcon with the final URL for the release

build/org.eclipse.cdt.managedbuilder.ui/OSGI-INF/org.eclipse.cdt.managedbuilder.internal.ui.compilationdatabase.PreferenceConfigurationAccess.xml

@@ -5,6 +5,6 @@
    </service>
    <reference cardinality="0..1" field="enable" interface="org.eclipse.cdt.managedbuilder.internal.ui.compilationdatabase.GenerateCDBEnable" name="enable"/>
    <reference cardinality="1..1" field="metadata" interface="org.eclipse.cdt.managedbuilder.internal.ui.compilationdatabase.PreferencesMetadata" name="metadata"/>
-   <reference cardinality="1..1" field="workspace" interface="org.eclipse.core.resources.IWorkspace" name="workspace"/>
+   <reference cardinality="1..1" field="workspace" interface="IWorkspace" name="workspace"/>
    <implementation class="org.eclipse.cdt.managedbuilder.internal.ui.compilationdatabase.PreferenceConfigurationAccess"/>
 </scr:component>

pom.xml

@@ -272,8 +272,6 @@
 		<!-- Documentation -->
 		<module>remote/org.eclipse.remote.doc.isv</module>
 
-		<module>terminal</module>
-
 		<module>jsoncdb</module>
 		<module>cmake</module>
 
@@ -302,6 +300,8 @@
 		<module>dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.ui.tests</module>
 		<module>jtag/org.eclipse.cdt.debug.gdbjtag.core.tests</module>
 		<module>memory/org.eclipse.cdt.debug.core.memory.tests</module>
+		<module>remote/org.eclipse.tm.terminal.connector.remote.feature</module>
+		<module>serial/org.eclipse.tm.terminal.connector.cdtserial.feature</module>
 		<module>testsrunner/org.eclipse.cdt.testsrunner.tests</module>
 
 		<module>releng/org.eclipse.cdt.testing</module>

releng/CDT.setup

@@ -305,7 +305,7 @@
             project="org.eclipse.cdt"/>
         <operand
             xsi:type="workingsets:ExclusionPredicate"
-            excludedWorkingSet="//'cdt.workingsets'/@workingSets[name='CDT%20Json%20CDB'] //'cdt.workingsets'/@workingSets[name='CDT%20JTag'] //'cdt.workingsets'/@workingSets[name='CDT%20Launch'] //'cdt.workingsets'/@workingSets[name='CDT%20Launchbar'] //'cdt.workingsets'/@workingSets[name='CDT%20Releng'] //'cdt.workingsets'/@workingSets[name='CDT%20Remote'] //'cdt.workingsets'/@workingSets[name='CDT%20Terminal'] //'cdt.workingsets'/@workingSets[name='CDT%20Build'] //'cdt.workingsets'/@workingSets[name='CDT%20CMake'] //'cdt.workingsets'/@workingSets[name='CDT%20Codan'] //'cdt.workingsets'/@workingSets[name='CDT%20Core'] //'cdt.workingsets'/@workingSets[name='CDT%20Cross'] //'cdt.workingsets'/@workingSets[name='CDT%20Debug'] //'cdt.workingsets'/@workingSets[name='CDT%20DSF'] //'cdt.workingsets'/@workingSets[name='CDT%20DSF%20GDB'] //'cdt.workingsets'/@workingSets[name='CDT%20Doc'] //'cdt.workingsets'/@workingSets[name='CDT%20LLVM'] //'cdt.workingsets'/@workingSets[name='CDT%20Memory'] //'cdt.workingsets'/@workingSets[name='CDT%20Serial'] //'cdt.workingsets'/@workingSets[name='CDT%20Tests%20Runner'] //'cdt.workingsets'/@workingSets[name='CDT%20Tools%20Templates'] //'cdt.workingsets'/@workingSets[name='CDT%20Unit%20Test'] //'cdt.workingsets'/@workingSets[name='CDT%20Util'] //'cdt.workingsets'/@workingSets[name='CDT%20Visualizer'] //'cdt.workingsets'/@workingSets[name='CDT%20Windows']"/>
+            excludedWorkingSet="//'cdt.workingsets'/@workingSets[name='CDT%20Json%20CDB'] //'cdt.workingsets'/@workingSets[name='CDT%20JTag'] //'cdt.workingsets'/@workingSets[name='CDT%20Launch'] //'cdt.workingsets'/@workingSets[name='CDT%20Launchbar'] //'cdt.workingsets'/@workingSets[name='CDT%20Releng'] //'cdt.workingsets'/@workingSets[name='CDT%20Remote'] //'cdt.workingsets'/@workingSets[name='CDT%20Build'] //'cdt.workingsets'/@workingSets[name='CDT%20CMake'] //'cdt.workingsets'/@workingSets[name='CDT%20Codan'] //'cdt.workingsets'/@workingSets[name='CDT%20Core'] //'cdt.workingsets'/@workingSets[name='CDT%20Cross'] //'cdt.workingsets'/@workingSets[name='CDT%20Debug'] //'cdt.workingsets'/@workingSets[name='CDT%20DSF'] //'cdt.workingsets'/@workingSets[name='CDT%20DSF%20GDB'] //'cdt.workingsets'/@workingSets[name='CDT%20Doc'] //'cdt.workingsets'/@workingSets[name='CDT%20LLVM'] //'cdt.workingsets'/@workingSets[name='CDT%20Memory'] //'cdt.workingsets'/@workingSets[name='CDT%20Serial'] //'cdt.workingsets'/@workingSets[name='CDT%20Tests%20Runner'] //'cdt.workingsets'/@workingSets[name='CDT%20Tools%20Templates'] //'cdt.workingsets'/@workingSets[name='CDT%20Unit%20Test'] //'cdt.workingsets'/@workingSets[name='CDT%20Util'] //'cdt.workingsets'/@workingSets[name='CDT%20Visualizer'] //'cdt.workingsets'/@workingSets[name='CDT%20Windows']"/>
       </predicate>
     </workingSet>
     <workingSet
@@ -440,13 +440,6 @@
           project="org.eclipse.cdt"
           relativePathPattern="remote/.*"/>
     </workingSet>
-    <workingSet
-        name="CDT Terminal">
-      <predicate
-          xsi:type="predicates:RepositoryPredicate"
-          project="org.eclipse.cdt"
-          relativePathPattern="terminal/.*"/>
-    </workingSet>
     <workingSet
         name="CDT Tests Runner">
       <predicate

releng/scripts/check_features.sh

@@ -56,6 +56,18 @@ git ls-files -- \*/feature.xml | while read feature_xml; do
         # early copyright year.
         feature_start_year=2015
         ;;
+    remote/org.eclipse.tm.terminal.connector.remote.feature/feature.xml)
+        # The git history does not show the proper start year for cmake because of https://github.com/eclipse-cdt/cdt/pull/1360
+        # Note, we can't simply use --follow because that causes other features to have a too
+        # early copyright year.
+        feature_start_year=2015
+        ;;
+    serial/org.eclipse.tm.terminal.connector.cdtserial.feature/feature.xml)
+        # The git history does not show the proper start year for cmake because of https://github.com/eclipse-cdt/cdt/pull/1360
+        # Note, we can't simply use --follow because that causes other features to have a too
+        # early copyright year.
+        feature_start_year=2018
+        ;;
     *)
         feature_start_year=$(git log --reverse --format='%ad' --date="format:%Y" -- $feature_xml $plugin_dir | head -1)
         ;;