Skip to content

Commit 5783b82

Browse files
raghucssitruspl-afed
authored andcommitted
Disable Toggle Instruction Step Mode command using activity support.
TISM command is always visible if the CDT Debug UI plug-in is not loaded yet. This happened due to platform limitation.So handle visibility using activity support. see #1220
1 parent a03e303 commit 5783b82

File tree

2 files changed

+39
-0
lines changed

2 files changed

+39
-0
lines changed

debug/org.eclipse.cdt.debug.ui/plugin.properties

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -282,3 +282,10 @@ popup.stepIntoSelection.name=Step Into Selection
282282
DebuggerConsoleView.name=Debugger Console
283283

284284
GenericTarget.name=Generic Target
285+
286+
# Toggle Instruction Step Mode Command Activity support
287+
org.eclipse.cdt.debug.ui.category.name=C/C++ Debug UI
288+
org.eclipse.cdt.debug.ui.category.description=Controls visibility of C/C++ Debug UI contributions
289+
290+
org.eclipse.cdt.debug.ui.activity.toggleInstructionStepMode.name=Instruction Step Mode Button on main Toolbar
291+
org.eclipse.cdt.debug.ui.activity.toggleInstructionStepMode.description=Control visibility of 'Toggle Instruction Step Mode' button on the main Toolbar

debug/org.eclipse.cdt.debug.ui/plugin.xml

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1302,6 +1302,7 @@
13021302
disabledIcon="icons/dlcl16/instr_step.gif"
13031303
helpContextId="toggle_instruction_step_mode_action_context"
13041304
icon="icons/elcl16/instr_step.gif"
1305+
id="main.run.menu:org.eclipse.cdt.debug.ui.ToggleInstructionStepModeCommand"
13051306
label="%ToggleInstructionStepModeAction.label"
13061307
style="toggle"
13071308
tooltip="%ToggleInstructionStepModeAction.tooltip">
@@ -1321,6 +1322,7 @@
13211322
disabledIcon="icons/dlcl16/instr_step.gif"
13221323
helpContextId="toggle_instruction_step_mode_action_context"
13231324
icon="icons/elcl16/instr_step.gif"
1325+
id="main.toolbar:org.eclipse.cdt.debug.ui.ToggleInstructionStepModeCommand"
13241326
label="%ToggleInstructionStepModeAction.label"
13251327
style="toggle"
13261328
tooltip="%ToggleInstructionStepModeAction.tooltip">
@@ -2675,5 +2677,35 @@
26752677
name="%GenericTarget.name">
26762678
</wizard2>
26772679
</extension>
2680+
2681+
<!-- Activity definition that controls the visibility of Toggle Instruction Step Mode command-->
2682+
<extension point="org.eclipse.ui.activities">
2683+
<category
2684+
id="org.eclipse.cdt.debug.ui.category"
2685+
name="%org.eclipse.cdt.debug.ui.category.name"
2686+
description="%org.eclipse.cdt.debug.ui.category.description">
2687+
</category>
2688+
2689+
<activity
2690+
id="org.eclipse.cdt.debug.ui.activity.toggleInstructionStepMode"
2691+
name="%org.eclipse.cdt.debug.ui.activity.toggleInstructionStepMode.name"
2692+
description="%org.eclipse.cdt.debug.ui.activity.toggleInstructionStepMode.description">
2693+
</activity>
2694+
2695+
<activityPatternBinding
2696+
activityId="org.eclipse.cdt.debug.ui.activity.toggleInstructionStepMode"
2697+
pattern="org\.eclipse\.cdt\.debug\.ui/main\.toolbar:org\.eclipse\.cdt\.debug\.ui\.ToggleInstructionStepModeCommand">
2698+
</activityPatternBinding>
2699+
<activityPatternBinding
2700+
activityId="org.eclipse.cdt.debug.ui.activity.toggleInstructionStepMode"
2701+
pattern="org\.eclipse\.cdt\.debug\.ui/main\.run\.menu:org\.eclipse\.cdt\.debug\.ui\.ToggleInstructionStepModeCommand">
2702+
</activityPatternBinding>
2703+
2704+
<categoryActivityBinding
2705+
activityId="org.eclipse.cdt.debug.ui.activity.toggleInstructionStepMode"
2706+
categoryId="org.eclipse.cdt.debug.ui.category">
2707+
</categoryActivityBinding>
2708+
</extension>
2709+
26782710

26792711
</plugin>

0 commit comments

Comments
 (0)