Improve the ergonomics of the Preferences page

[SkytAsul]

Bug description

In the rich presence on Discord, I see "Editing ?" if I have disabled the option "Show file name".

Expected behavior

The line "Editing x" should be completely hidden if this option is disabled.

How to reproduce

Steps to reproduce the behavior:

1. Go to 'Discord Rich Presence' in the Eclipse preferences
2. Disable 'Show file name' and apply
3. Go to discord and click on your profile
4. Witness the error

Additional context

• Plug-in version: 1.2.0
• Eclipse IDE version: 2020-03 (4.15.0)

[echebbi]

This is actually the expected behavior. As mentioned in the changelog, as of v1.1.3 the "right" way to hide a whole line in Discord is through custom wording (in your case, emptying the Details field should do the trick).

I'd appreciate a feedback about this though. I basically had two choices to handle privacy when I added custom wording:

1. replace secret variables by "?",
2. completely hide any field using a secret variable.

I chose the former and updated the default behavior for consistency. I see two approaches to solve your issue:

1. I can restore the old behavior by hiding the whole Editing x field if Show file name is unchecked and if no custom wording is provided but it feels, well, inconsistent.
2. I can try to make the preferences page more ergonomic to make clearer that hiding a line requires to specify a custom wording.

What's your opinion on this?

[SkytAsul]

Ohh I didn't know that! Thank you, this fixed my problem ^^
The second option seems to be the better: users can still do whatever they want but Rich Presence noobs like me understand what's going on!

[echebbi]

Thanks. I'll do that as soon as possible and leave the issue open until then.