fix #185

Author: eblondel

R/SDMXServiceProvider-methods.R

@@ -387,6 +387,69 @@ setSDMXServiceProviders <- function(){ # nocov start
   #  )
   #)
 
+  #Bundesbank
+  BBK <- SDMXServiceProvider(
+    agencyId = "BBK", name = "Bundesbank",
+    scale = "national", country = "DEU",
+    builder = SDMXRequestBuilder(
+      regUrl = "https://api.statistiken.bundesbank.de/rest/metadata",
+      repoUrl = "https://api.statistiken.bundesbank.de/rest",
+      formatter = list(
+        dataflow = function(obj){return(obj)},
+        datastructure = function(obj){return(obj)},
+        data = function(obj){return(obj)}
+      ),
+      #resource handler
+      handler = list(
+        
+        #dataflow resource (dataflow/agencyID/resourceID/version)
+        #-----------------------------------------------------------------------
+        dataflow = function(obj){
+          req <- sprintf("%s/dataflow/%s",obj@regUrl, obj@providerId)
+          if(!is.null(obj@resourceId)) req <- paste(req, obj@resourceId, sep = "/")
+          return(req)
+        },
+        
+        #datastructure resource (datastructure/agencyID/resourceID/version)
+        #--------------------------------------------------------------------------------
+        datastructure = function(obj){
+          req <- sprintf("%s/datastructure/%s",obj@regUrl, obj@providerId)
+          if(!is.null(obj@resourceId)) req <- paste(req, obj@resourceId, sep = "/")
+          req <- paste0(req, "?references=children") #TODO to see later to have arg for this
+          return(req)
+        },
+        
+        #data resource (data/flowRef/key/providerRef)
+        #----------------------------------------------------------
+        data = function(obj){
+          if(is.null(obj@flowRef)) stop("Missing flowRef value")
+          req <- sprintf("%s/data/%s/%s",obj@repoUrl, obj@flowRef, obj@key)
+          
+          #DataQuery
+          #-> temporal extent (if any)
+          addParams = FALSE
+          if(!is.null(obj@start)){
+            req <- paste0(req, "?")
+            addParams = TRUE
+            req <- paste0(req, "startPeriod=", obj@start)
+          }
+          if(!is.null(obj@end)){
+            if(!addParams){
+              req <- paste0(req, "?")
+            }else{
+              req <- paste0(req, "&")
+            }
+            req <- paste0(req, "endPeriod=", obj@end) 
+          }
+          
+          return(req)
+        }
+      ),
+      compliant = FALSE
+    )
+  )
+  
+  
   #other data providers
   #--------------------
 
@@ -440,7 +503,7 @@ setSDMXServiceProviders <- function(){ # nocov start
     #international
     BIS, ECB, ESTAT, IMF, OECD, UNICEF, CD2030, UNSD, ILO_Legacy, ILO, WBG_WITS, WB, PDH,
     #national
-    ABS, NBB, INSEE, INEGI, ISTAT, NOMIS, LSD, NCSI, STAT_EE,
+    ABS, NBB, INSEE, INEGI, ISTAT, NOMIS, LSD, NCSI, STAT_EE, BBK,
     #others
     KNOEMA
   )

R/SDMXServiceProviders-methods.R

@@ -31,4 +31,4 @@ as.data.frame.SDMXServiceProviders <- function(x, ...){
 }
 
 setAs("SDMXGenericData", "data.frame",
-      function(from) {as.data.frame.SDMXServiceProviders(from)});
+      function(from) {as.data.frame.SDMXServiceProviders(from)})

tests/testthat/test_Main_Helpers.R

@@ -729,6 +729,34 @@ test_that("STAT_EE - data",{
 })
 
 
+#BBK (Bundesbank)
+#-------------
+#-> dataflow
+test_that("BBK - dataflow",{
+  testthat::skip_on_cran()
+  sdmx <- readSDMX(providerId = "BBK", resource = "dataflow")
+  if(!is.null(sdmx)){
+    expect_is(sdmx, "SDMXDataFlows")
+  }
+})
+
+test_that("BBK - datastructure",{
+  testthat::skip_on_cran()
+  sdmx <- readSDMX(providerId = "BBK", resource = "datastructure", resourceId = "BBK_SEDI")
+  if(!is.null(sdmx)){
+    expect_is(sdmx, "SDMXDataStructureDefinition")
+  }
+})
+
+test_that("BBK - data",{
+  testthat::skip_on_cran()
+  sdmx <- readSDMX(providerId = "BBK", resource = "data", flowRef = "BBSIS", key = "D.I.ZST.B0.EUR.S1311.B.A604._Z.R.A.A._Z._Z.A")
+  if(!is.null(sdmx)){
+    expect_is(sdmx, "SDMXGenericData")
+  }
+})
+
+
 #other data providers
 
 #KNOEMA