Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_rename(): "Error: Following variable(s) were not found" in version '0.13.0.17' #572

Merged
merged 12 commits into from
Dec 13, 2024

Conversation

strengejacke
Copy link
Member

Fixes #571

@strengejacke strengejacke marked this pull request as ready for review December 13, 2024 08:59
@strengejacke
Copy link
Member Author

I think this can be merged, but @etiennebacher, do you know why the docs for rescale() inherit the @details section from data_rename()?

R/data_rename.R Show resolved Hide resolved
tests/testthat/test-data_rename.R Outdated Show resolved Hide resolved
@etiennebacher
Copy link
Member

etiennebacher commented Dec 13, 2024

do you know why the docs for rescale() inherit the @details section from data_rename()?

No idea why, can you remove it?


Edit: as an aside, the order of docs in rescale() is not great. I think it's clearer to have @examples last and all the other roxygen tags (return, etc.) before

@strengejacke
Copy link
Member Author

do you know why the docs for rescale() inherit the @details section from data_rename()?

No idea why, can you remove it?

I tried to, bust failed - however, just realized there is a @inherit data_rename tag, which is probably only accidentally there. Removing it fixes the issue.

@strengejacke strengejacke merged commit a4a8308 into main Dec 13, 2024
21 of 22 checks passed
@strengejacke strengejacke deleted the strengejacke/issue571 branch December 13, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data_rename(): "Error: Following variable(s) were not found" in version '0.13.0.17'
2 participants