Skip to content

Commit df880a4

Browse files
Remove unused register method from CalculatorFactory
1 parent ec73133 commit df880a4

File tree

2 files changed

+0
-42
lines changed

2 files changed

+0
-42
lines changed

src/easydiffraction/analysis/calculators/calculator_factory.py

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
# SPDX-FileCopyrightText: 2021-2025 EasyDiffraction Python Library contributors <https://github.com/easyscience/diffraction-lib>
22
# SPDX-License-Identifier: BSD-3-Clause
33

4-
from typing import Any
54
from typing import Dict
65
from typing import List
76
from typing import Optional
@@ -71,30 +70,3 @@ def create_calculator(cls, calculator_name: str) -> Optional[CalculatorBase]:
7170
return None
7271

7372
return config['class']()
74-
75-
@classmethod
76-
def register_calculator(
77-
cls,
78-
calculator_type: str,
79-
calculator_cls: Type[CalculatorBase],
80-
description: str = 'No description provided.',
81-
) -> None:
82-
cls._potential_calculators[calculator_type] = {
83-
'class': calculator_cls,
84-
'description': description,
85-
}
86-
87-
@classmethod
88-
def register_minimizer(
89-
cls,
90-
name: str,
91-
minimizer_cls: Type[Any],
92-
method: Optional[str] = None,
93-
description: str = 'No description provided.',
94-
) -> None:
95-
cls._available_minimizers[name] = {
96-
'engine': name,
97-
'method': method,
98-
'description': description,
99-
'class': minimizer_cls,
100-
}

tests/unit/analysis/calculators/test_calculator_factory.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -63,17 +63,3 @@ def test_create_calculator_unknown(mock_calculators):
6363

6464
# Assertions
6565
assert unknown_calculator is None
66-
67-
68-
def no_test_register_calculator():
69-
class MockCalculator:
70-
engine_imported = True
71-
72-
CalculatorFactory.register_calculator('mock_calculator', MockCalculator, description='Mock calculator for testing')
73-
74-
supported = CalculatorFactory._supported_calculators()
75-
76-
# Assertions
77-
assert 'mock_calculator' in CalculatorFactory._potential_calculators
78-
assert supported['mock_calculator']['description'] == 'Mock calculator for testing'
79-
assert supported['mock_calculator']['class'] == MockCalculator

0 commit comments

Comments
 (0)