Fixes unit tests for non-returning calculate pattern

Author: AndrewSazonov

tests/unit/analysis/calculators/test_calculator_base.py

@@ -52,7 +52,8 @@ def test_calculate_pattern(mock_constraints_handler, mock_sample_models, mock_ex
     mock_constraints_handler.return_value.apply = MagicMock()
 
     calculator = MockCalculator()
-    result = calculator.calculate_pattern(mock_sample_models, mock_experiment)
+    calculator.calculate_pattern(mock_sample_models, mock_experiment)
+    result = mock_experiment.datastore.pattern.calc
 
     # Assertions
     assert np.allclose(result, np.array([3.6, 7.2, 10.8]))

tests/unit/analysis/test_minimization.py

@@ -41,7 +41,9 @@ def mock_experiments():
 @pytest.fixture
 def mock_calculator():
     calculator = MagicMock()
-    calculator.calculate_pattern.return_value = np.array([9.0, 19.0, 29.0])
+    def mock_calculate_pattern(sample_models, experiment, **kwargs):
+        experiment.datastore.pattern.calc = np.array([9.0, 19.0, 29.0])
+    calculator.calculate_pattern.side_effect = mock_calculate_pattern
     return calculator
 
 

tests/unit/analysis/test_reliability_factors.py

@@ -98,7 +98,9 @@ def test_get_reliability_inputs():
             )
         )
     }
-    calculator.calculate_pattern.return_value = np.array([9.0, 19.0, 29.0])
+    def mock_calculate_pattern(sample_models, experiment, **kwargs):
+        experiment.datastore.pattern.calc = np.array([9.0, 19.0, 29.0])
+    calculator.calculate_pattern.side_effect = mock_calculate_pattern
 
     y_obs, y_calc, y_err = get_reliability_inputs(sample_models, experiments, calculator)