Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Search results omits HTML tags #455

Open
SethFalco opened this issue Sep 7, 2024 · 1 comment
Open

Regression: Search results omits HTML tags #455

SethFalco opened this issue Sep 7, 2024 · 1 comment

Comments

@SethFalco
Copy link

SethFalco commented Sep 7, 2024

I'm looking at upgrading Docusaurus and the plugins we're using, but I think there's a regression between v0.40.1 and v0.41.0 which degrades the search experience.

It does not handle HTML tags in content well anymore.

Our documentation contains the following:

Removes the [`<metadata>`](https://developer.mozilla.org/docs/Web/SVG/Element/metadata) element from the document.

Before (v0.40.1)

This version kept the name of the HTML element, and omitted the Markdown syntax. The result was perfect in my opinion.

After (>= v0.41.0, including v0.44.5)

This version only keeps the backticks in the Markdown, and nothing inside it.

@weareoutman
Copy link
Member

weareoutman commented Sep 9, 2024

image

I can't reproduce it.

According to your screenshot of after updating, the issue seems not to be related with the search plugin. It seems to be an issue with your markdown renderer.

Under the hood, we scan the generated html files to build the search index, if the markdown renders correctly, there will be no backticks in the generated html (should be <code></code> instead).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants