You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think this is best done by removing com.eharmony.aloha.io.fs._ and placing any necessary functionality in com.eharmony.aloha.io.vfs. This is for a few reasons.
aloha-vw-jni and aloha-h2o use com.eharmony.aloha.io.vfs
com.eharmony.aloha.io.fs stupidly has the sealed traitFsInstance inside a package object. Since the classes are inner classes of the class package in the package com.eharmony.aloha.io.fs, the code can't (or at least can't easily) be used in Java.
Other classes in aloha.io use the aloha.io.fs package. This is especially true of aloha.io.sources._. These would have to be retrofitted to work with the aloha.io.vfs code.
This is a semantic versioning major version number bump and should be done as part of aloha 5.x.
The text was updated successfully, but these errors were encountered:
I think this is best done by removing
com.eharmony.aloha.io.fs._
and placing any necessary functionality incom.eharmony.aloha.io.vfs
. This is for a few reasons.aloha-vw-jni
andaloha-h2o
usecom.eharmony.aloha.io.vfs
com.eharmony.aloha.io.fs
stupidly has the sealed traitFsInstance
inside a package object. Since the classes are inner classes of the classpackage
in the packagecom.eharmony.aloha.io.fs
, the code can't (or at least can't easily) be used in Java.Other classes in
aloha.io
use thealoha.io.fs
package. This is especially true ofaloha.io.sources._
. These would have to be retrofitted to work with thealoha.io.vfs
code.This is a semantic versioning major version number bump and should be done as part of aloha 5.x.
The text was updated successfully, but these errors were encountered: